restored benches from orig repo with minor refactoring #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
holy shit - is it possible that moving into pure rust secp made a huge leap in performance ? Can you run test for signing and not just keygen ? |
|
I wouldn't say huge - though seems a bit significant, closing this pr in favor of #9 that is just continuation on a renamed branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - restored benches from orig repo with minor refactoring (removed duplicated code in gg18 keygen.rs bench) wanted to merge it first but noticed you merged already #6 . Anyway seems from point of performance libsecp256k1 crate is ok anyway - here are some pics with times
your original multi-party-ecdsa by KZen
64 bit: x86_64-unknown-linux-gnu on nightly-x86_64-unknown-linux-gnu
prior secp256k1 crate (C based)
32bit: i686-pc-windows-msvc on nightly-i686-pc-windows-msvc
64 bit: x86_64-pc-windows-msvc on nightly-x86_64-pc-windows-msvc
64 bit: x86_64-unknown-linux-gnu on nightly-x86_64-unknown-linux-gnu
Now current libsecp256k1 crate (pure Rust)
32bit: i686-pc-windows-msvc on nightly-i686-pc-windows-msvc
64 bit: x86_64-pc-windows-msvc on nightly-x86_64-pc-windows-msvc
64 bit: x86_64-unknown-linux-gnu on nightly-x86_64-unknown-linux-gnu