Added a check for the length of PDLwSlackProof vector. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, no worries! I've been also quite overloaded in the past few days. This looks quite good! |
|
Sure, it's easy. I'll add it tomorrow. |
…, returning proper error if this check fails.
|
I actually moved the check inside the |
|
Hey Matan!
Could we merge the PR when you'll have the time?
…On Sat, Jan 29, 2022 at 9:50 PM Matan Hamilis ***@***.***> wrote:
Hey, no worries! I've been also quite overloaded in the past few days.
This looks quite good!
It is totally up to you, do you think you would be able to add the code to
identify the misbehaving parties?
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMX46ROV27RPC2AE24WCOTUYRAJPANCNFSM5MWWDULQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Forgot to look into this, thanks for reminding! |
HRezaei
pushed a commit
to HRezaei/multi-party-ecdsa
that referenced
this pull request
Feb 22, 2022
* Added a check for the length of PDLwSlackProof vector. * Moved check for the length of PDLwSlackProof vector inside party_i.rs, returning proper error if this check fails. * Forgot to run rustfmt :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @MatanHamilis! Sorry for taking so long to write two lines of code. Quite frankly, I just forgot about this. I think there are no more places in the code where the length check needs to be performed (in keygen round 3 and sign round 2, P2P container is used where parties need to send a list of messages).
PS. I only added an
assert_eq, without returning the vector of misbehaving parties. When implementing identifiable aborts, this should be changed. Or I can do it now.