Skip to content
This repository was archived by the owner on Jan 14, 2022. It is now read-only.

Commit 3ad5c42

Browse files
committed
updated check for require in code-editor
1 parent 9a3d8c0 commit 3ad5c42

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

app/app-main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const { app, Menu, ipcMain } = require('electron')
2-
const { pageView } = require('../browser/lib/analytics')
2+
// const { pageView } = require('../browser/lib/analytics')
33

44
let mainWindow = null
55

@@ -23,7 +23,7 @@ if (isSecondInstance) {
2323
}
2424

2525
app.on('ready', () => {
26-
pageView('/main-process')
26+
// pageView('/main-process')
2727
mainWindow = require('./app-window')(app)
2828
require('./app-tray')(app, mainWindow)
2929
ipcMain.on('bringToFront', () => {

browser/render/components/code-editor/index.jsx

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ export default class CodeEditor extends React.Component {
1919
if (snippet) {
2020
const { theme, showLineNumber, highlightCurrentLine } = config.editor
2121
const snippetMode = CodeMirror.findModeByName(snippet.lang).mode
22-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
22+
if (snippetMode && snippetMode !== 'null') {
23+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
24+
}
2325
const gutters = showLineNumber
2426
? ['CodeMirror-linenumbers', 'CodeMirror-foldgutter']
2527
: []
@@ -64,7 +66,9 @@ export default class CodeEditor extends React.Component {
6466
let snippetMode = 'null'
6567
if (resultMode) {
6668
snippetMode = resultMode.mode
67-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
69+
if (snippetMode && snippetMode !== 'null') {
70+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
71+
}
6872
}
6973

7074
const gutters = showLineNumber
@@ -113,7 +117,9 @@ export default class CodeEditor extends React.Component {
113117
onUpdateSingleFileSnippet (props) {
114118
const { snippet } = props
115119
const snippetMode = CodeMirror.findModeByName(snippet.lang).mode
116-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
120+
if (snippetMode && snippetMode !== 'null') {
121+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
122+
}
117123
this.editor.setValue(snippet.value)
118124
this.editor.setOption('mode', snippetMode)
119125
}
@@ -129,7 +135,9 @@ export default class CodeEditor extends React.Component {
129135
let snippetMode = 'null'
130136
if (resultMode) {
131137
snippetMode = resultMode.mode
132-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
138+
if (snippetMode && snippetMode !== 'null') {
139+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
140+
}
133141
}
134142

135143
this.editor.setOption('mode', snippetMode)
@@ -152,7 +160,9 @@ export default class CodeEditor extends React.Component {
152160
// only update codemirror mode if new props is passed
153161
if (props) {
154162
const snippetMode = CodeMirror.findModeByName(snippet.lang).mode
155-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
163+
if (snippetMode && snippetMode !== 'null') {
164+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
165+
}
156166
}
157167
const gutters = showLineNumber
158168
? ['CodeMirror-linenumbers', 'CodeMirror-foldgutter']
@@ -208,7 +218,9 @@ export default class CodeEditor extends React.Component {
208218
let snippetMode = 'null'
209219
if (resultMode) {
210220
snippetMode = resultMode.mode
211-
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
221+
if (snippetMode && snippetMode !== 'null') {
222+
require(`codemirror/mode/${snippetMode}/${snippetMode}`)
223+
}
212224
}
213225
}
214226

0 commit comments

Comments
 (0)