Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalan Version #93

Closed
wants to merge 25 commits into from
Closed

Conversation

victorfancelli
Copy link

This is the pull request with the Catalan version. There are minor changes in the English versions but the rest should not create problems

As mentioned on #92 :

  • I deleted the flag for Catalan.
  • I copied (not Symlink) the img folder: probably is better this way. I added some images in the en/img for the 5 minutes guide which is not (yet?) available in English.
  • I add a small message at the beginning of ca/index.md saying that the documentation is still in progress and recommend to check other languages and linking Github for collaborations. I wanted to stress that there actually is a lot of documentation, just not yet translated. (For the moment there is only installation and getting started). When translation is mature, I will delete the message.

Copy link
Member

@nathanlesage nathanlesage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, I couldn't spot any errors except the one I mentioned in an additional comment about the symbolic link to the application CSS! If that's done we can merge!

@@ -0,0 +1 @@
/home/victor/zettlr-docs/zettlr-docs/assets/app.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a hard link to the file on your own computer, but for it to work here on the CI pipeline, it needs to be relative (I think the contents of this link need to be ../../../assets/app.css)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups!

now should work

@nathanlesage
Copy link
Member

I have reviewed your PR, looks all good except one minor thing (see my comment on that!)

I added some images in the en/img for the 5 minutes guide which is not (yet?) available in English.

Do you mean the Quickstart guide? I remember vaguely that I have renamed that at one point, but I'm not sure!

I add a small message at the beginning of ca/index.md saying that the documentation is still in progress and recommend to check other languages and linking Github for collaborations. I wanted to stress that there actually is a lot of documentation, just not yet translated. (For the moment there is only installation and getting started). When translation is mature, I will delete the message.

That sounds perfectly reasonable!

@victorfancelli
Copy link
Author

Do you mean the Quickstart guide? I remember vaguely that I have renamed that at one point, but I'm not sure!

Yes: I didn't find an English equivalent of Quickstart/5-minutes- guide in the docs, as there is in the German version https://docs.zettlr.com/de/5-minutes/
Should I translate it?

@nathanlesage
Copy link
Member

If you think that would help prospective readers, sure, why not! The docs are free for all :)

@nathanlesage
Copy link
Member

Due to the age of this PR and now existing merge conflicts, I'll close this PR now. I'd be happy to include the Catalan translation at a future point, but please open a new PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants