Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble Sort script and documentation #1

Closed
Zircoz opened this issue Oct 9, 2019 · 8 comments

Comments

@Zircoz
Copy link
Owner

commented Oct 9, 2019

Write a neat program for Bubble sort in python with a clear and helpful documentation.

@SaxenaKartik

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

I would like to work on this

@Zircoz

This comment has been minimized.

Copy link
Owner Author

commented Oct 9, 2019

@SaxenaKartik Sure, fork it and create a PR when done. All the best.

SaxenaKartik added a commit to SaxenaKartik/Sorting-Algorithms-in-Python that referenced this issue Oct 9, 2019
@subhadeep-deyashi

This comment has been minimized.

Copy link

commented Oct 10, 2019

What is an appropriate issue number?

@Zircoz

This comment has been minimized.

Copy link
Owner Author

commented Oct 11, 2019

What is an appropriate issue number?

I think you know now.

@Zircoz

This comment has been minimized.

Copy link
Owner Author

commented Oct 11, 2019

@crandalj I may not notice if you make PR for anything until you mention me or refer the issue in it.

Now, if @SaxenaKartik doesn't complete the changes requested in next 2 days, I will reopen your PR #7 and approve it purely on its merit of being more useful. And because he requested to take upon this issue first.

@subhadeep-deyashi

This comment has been minimized.

Copy link

commented Oct 12, 2019

@Zircoz

This comment has been minimized.

Copy link
Owner Author

commented Oct 12, 2019

OKay @subhadeep-deyashi , no worries.
This repo is made to help first timers.

I think you will find this useful: https://www.digitalocean.com/community/tutorial_series/an-introduction-to-open-source

Zircoz added a commit that referenced this issue Oct 12, 2019
#1 Added Bubble Sort Algorithm and Documentation
@Zircoz

This comment has been minimized.

Copy link
Owner Author

commented Oct 12, 2019

@SaxenaKartik made the changes requested so I am closing this issue now, for submitting any improvements to the code create new issue.

CC: @subhadeep-deyashi @crandalj

@Zircoz Zircoz closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.