The current v1.2 git tag is lightweight; please make it into an annotated tag

[anthonyfok]

Hello @russross,

While trying to update the blackfriday package for Debian, I was surprised that the automated dh-make-golang tool (https://github.com/Debian/dh-make-golang) created an erroneous upstream version of 1.1+git20150720.80.8cec3a8 when v1.2 was released a year ago.

Digging deeper, it turns out that dh-make-golang got the v1.1 from git describe --abbrev=0, skipping v1.2 because v1.2 is currently a lightweight tag, whereas v1.1 and v1.0 were correctly tagged as annotated tags.

Automated tools like dh-make-golang aside, I think it would confuse the end users too when they type in git describe and see this:

$ git describe
v1.1-216-g8cec3a8

I could get git describe to match v1.2 too by using --tags, but it shouldn't be necessary:

$ git describe --tags 
v1.2-80-g8cec3a8

So yes, it would be great if you could fix that when you have time. It is a common problem (it is easy to forget to add the -a option when tagging), but the thankfully the fix is easy too, as described in the following Q&A and blog post:

• git - Can a lightweight tag be converted to an annotated tag? - Stack Overflow
• Replace a Lightweight Git Tag with an Annotated Tag

Thanks again!

Anthony

[tianon]

(Should probably also use uscan and debian/watch for this particular package instead of packaging a snapshot. 👍)

[anthonyfok]

@tianon, ideally, yes, but since Blackfriday v1.2 was released in August 2014, there has been some new features and flags, i.e. API changes, that Go applications like Hugo (https://github.com/spf13/hugo) now requires. (Hugo is probably the biggest user of the Blackfriday library.)

I have not seen any recent talks about wrapping up the recent changes into a Blackfriday v1.3 release yet, so uploading a snapshot would be a good interim solution.

[russross]

I deleted the old tag, re-created it (backdated) as an annotated tag, and
push it to github. Please let me know if I got it right or if I need to try
again.

Thanks for pointing out the problem!

On Tue, Sep 8, 2015 at 6:58 PM, Anthony Fok notifications@github.com
wrote:

@tianon https://github.com/tianon, ideally, yes, but since Blackfriday
v1.2 was released in August 2014, there has been some new features and
flags, i.e. API changes, that Go applications like Hugo (
https://github.com/spf13/hugo) now requires. (Hugo is probably the
biggest user of the Blackfriday library.)

I have not seen any recent talks about wrapping up the recent changes into
a Blackfriday v1.3 release yet, so uploading a snapshot would be a good
interim solution.

—
Reply to this email directly or view it on GitHub
#196 (comment)
.

[anthonyfok]

Thank you very much, Russ!
The new v1.2 tag looks great and works great!
Thanks for your help!