Fixes for release preparation v0.1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
requested changes
Jan 15, 2021
manufacturing/readme.md
Outdated
|  | ||
|
|
||
| 3) After flashing is done, all the PCBs should be stacked, aligned, and secured together using x5 2 mm diameter shafts. | ||
| "Part A" PCBs should be split in two parts beforehand, | ||
| and the excessive material that interferes with USB A connector placement should be removed. | ||
| The pins can be manufactured by cutting widely available round wooden dowels with 2 mm diameter to appropriate length (7.7 mm). |
There was a problem hiding this comment.
The pins can be manufactured
Do you mean shafts?
Also, the line is too long.
There was a problem hiding this comment.
They are actually pins. Will replace that.
There was a problem hiding this comment.
Okay but the line is still too long.
Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
pavel-kirienko
requested changes
Jan 15, 2021
manufacturing/readme.md
Outdated
|  | ||
|
|
||
| 3) After flashing is done, all the PCBs should be stacked, aligned, and secured together using x5 2 mm diameter shafts. | ||
| "Part A" PCBs should be split in two parts beforehand, | ||
| and the excessive material that interferes with USB A connector placement should be removed. | ||
| The pins can be manufactured by cutting widely available round wooden dowels with 2 mm diameter to appropriate length (7.7 mm). |
There was a problem hiding this comment.
Okay but the line is still too long.
|
All the changes in the PCB relate to the inner structure, especially the ASSEMBLY VARIANTS. The PCB itself was not changed. |
|
Line has been shorten now. |
pavel-kirienko
approved these changes
Jan 15, 2021
dimracer
pushed a commit
that referenced
this pull request
Jan 15, 2021
…ng) (#1) * Correct the docs (no substantial changes, mostly grammar and formatting) * Add links to Babel and DCP * Fixes for release preparation v0.1 (#3) * source files consistency fix * Delete part B.brd * Revert "Delete part B.brd" This reverts commit 4a45031. * Revert "source files consistency fix" This reverts commit 015ba01. * fixes for #1 * Update readme.md * Update readme.md * Update manufacturing/readme.md Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com> * Update readme.md * Update readme.md * Update readme.md Co-authored-by: Alexander Sysoev <alexander.sysoev@zubax.com> Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com> Co-authored-by: j3qq4hch <j3qq4hch@gmail.com> Co-authored-by: Alexander Sysoev <alexander.sysoev@zubax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.