Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GitHub actions to run golangci-lint #33

Merged
merged 3 commits into from
May 12, 2024

Conversation

ccoVeille
Copy link
Contributor

See #32

@Zxilly
Copy link
Owner

Zxilly commented May 11, 2024

Seems the yml file is broken: https://github.com/Zxilly/go-size-analyzer/actions/runs/9047167190

@ccoVeille
Copy link
Contributor Author

Seems the yml file is broken: https://github.com/Zxilly/go-size-analyzer/actions/runs/9047167190

thanks, fixed. I was wondering why it was not triggered

the idea is to make the code clearer
@Zxilly Zxilly merged commit 24a93da into Zxilly:master May 12, 2024
1 of 5 checks passed
@ccoVeille ccoVeille deleted the github-actions-ci branch May 12, 2024 00:44
@ccoVeille
Copy link
Contributor Author

ccoVeille commented May 12, 2024

You should launch golangci-lint run locally to identify and fix the issues reported.

Then the "new-issues-only" could be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants