Skip to content

The programming test that taught me React isn't horrible

Notifications You must be signed in to change notification settings

Zyzle/RockTracks

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

10 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Future work:

  • Testing: Right now there isn't any. I would start by adding some basic snapshot tests to the components checking that the HTML rendered is expected given a set of props. Next step after that would be to test the functionality of the reducer, as a pure function testing is simple to accomplish and will provide the most benefit as the majority of the app logic should be contained here or in the sagas.
  • Styling: As UI wasn't considered part of this test I haven't done any but it should be simple enough to make something that looks good with some basic scss.
  • Search parameters: It would be simple enough to paramaterise the search action to take in term and media values to allow searching for different items in the API

This project was bootstrapped with Create React App.

Available Scripts

In the project directory, you can run:

npm start

Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.
You will also see any lint errors in the console.

npm test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

npm run build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

npm run eject

Note: this is a one-way operation. Once you eject, you can’t go back!

If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.