Modify graphs.py to handle insertions when {'insertions': True}
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 40.27% // Head: 47.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 40.27% 47.93% +7.66%
==========================================
Files 48 85 +37
Lines 2811 5411 +2600
==========================================
+ Hits 1132 2594 +1462
- Misses 1679 2817 +1138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
The centroid coordinates of protein graphs contain NaN values when the PDB file contains at least one insertion and when
{'insertions': True}is provided to ProteinGraphConfigWhat does this implement/fix? Explain your changes
Adding the
insertionidentifier in the node_id and in the centroid atom grouping function solves the problemWhat testing did you do to verify the changes in this PR?
Graph creation for 1i7z.
ex:
before modifications: ['A:ASP:1', 'A:LEU:2', 'A:PRO:95', 'A:TRP:96', ...]
G.coords #=> contains NaNsafter modifications:before modifications: ['A:ASP:1', 'A:LEU:2', 'A:PRO:95', 'A:TRP:96', ...]
G.coords #=> no NaNPull Request Checklist
./CHANGELOG.mdfile (if applicable)./graphein/tests/*directories (if applicable)./notebooks/(if applicable)python -m py.test tests/and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py)black .andisort .