Call to undefined method Sabberworm\CSS\CSSList\AtRuleBlockList::getSelectors()

[markusa86]

Hi Armin,
nice work. I found an Issue.
CssCoverageService.php Line 86.
$selectors = $child->getSelectors(); <- $child could be an Instance of DeclarationBlock and has no method called getSelectors.
CSS Example from fancybox to reproduce:
@supports (padding: max(0px)) { .fancybox-caption { padding: 75px max(44px, env(safe-area-inset-right)) max(25px, env(safe-area-inset-bottom)) max(44px, env(safe-area-inset-left)); } }
maybe a recursive function is the bette way.
For my test I quick fixed it to:
if ($child instanceof AtRuleBlockList) and duplicated the block and it works perfect.

Regards.
Markus

[a-r-m-i-n]

Hi Markus,
thanks for your issue! I think I would prefer to check for method_exists instead for the instance because I don't know which other siblings may have this property set.

I also think recursion is not necessary, because there is no infinite nesting in CSS existing. You got media queries and inside the selectors, with their declarations, that's it.

However, the code duplication should get resolved with a separate method - it is also marked as "TODO".