Make it more modular #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I've been meaning to do some of this for a while, so I'll go ahead and merge it. |
aag
added a commit
that referenced
this pull request
Sep 19, 2019
This commit adds an option to supply a list of URLs for which the script will download all files, regardless of other settings. This allows the user to do something like only download Trailer #1 for most movies (with the `video_types = single_trailer` setting), but for movies the user is really interested in, to download all videos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i wanted to use your download functions in a program of mine.
Basically these changes allow importing your apple_trailer_downloader without executing the complete program and downloading everything. The original program was moved to the >> if name == 'main':<< part and global variables are now explicitly given to the functions.
greetings
robivanknobi