Remove benchmark params slot, type core decorators
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was redundant with the addition of the `runner.run()` params slot, and everything else can be handled directly via default arguments on the function itself. The parametrization factory was updated to take the resulting partial instead.
Previously, the decorator typing was suffering since no proper overloads were available for the parentheses vs. no parentheses cases. These are now added. As a consequence, both varieties for both decorators now result in sensible return types. This also paves the way for an easier implementation of the cartesian product decorator coming up. As a consequence of the removed params slot, the function in a parametrized benchmark is replaced by an update-wrapped partial, with the keyword arguments from the parametrization applied.
|
Addresses point 1) of #3. cc @maxmynter |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was redundant with the addition of the
runner.run()params slot, and everything else can be handled directly via default arguments on the function itself.The parametrization factory was updated to take the resulting partial instead.
Properly type and document the core decorators (d9a8d6b)
Previously, the decorator typing was suffering since no proper overloads were available for the parentheses vs. no parentheses cases. These are now added.
As a consequence, both varieties for both decorators now result in sensible return types. This also paves the way for an easier implementation of the cartesian product decorator coming up.
As a consequence of the removed params slot, the function in a parametrized benchmark is replaced by an update-wrapped partial, with the keyword arguments from the parametrization applied.