Don't instrument out-edges of assert false

Fixes #355.
aantron · Nov 3, 2020 · 0223008 · 0223008
1 parent 4de17d7
commit 0223008
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/ppx/instrument.ml b/src/ppx/instrument.ml
@@ -1249,6 +1249,9 @@ class instrumenter =
                 instrument_expr ~use_loc_of:e' ~post:true e
               end
 
+          | Pexp_assert [%expr false] ->
+            e
+
           | Pexp_assert e ->
             Exp.assert_ (traverse ~is_in_tail_position:false e)
             |> instrument_expr ~use_loc_of:e ~post:true

diff --git a/test/instrument/apply/assert.t b/test/instrument/apply/assert.t
@@ -6,3 +6,11 @@ Out-edge instrumented.
   let _ =
     ___bisect_post_visit___ 1
       (assert (___bisect_post_visit___ 0 (bool_of_string "true")))
+
+
+Not instrumented for assert false.
+
+  $ bash ../test.sh <<'EOF'
+  > let _ = assert false
+  > EOF
+  let _ = assert false
diff --git a/test/instrument/recent/refutation.t b/test/instrument/recent/refutation.t
@@ -40,23 +40,12 @@ instrumented.
            ___bisect_matched_value___
          with
         | `A ->
-            ___bisect_visit___ 1;
+            ___bisect_visit___ 0;
             ()
         | `B ->
-            ___bisect_visit___ 2;
+            ___bisect_visit___ 1;
             ()
         | _ -> ());
         ()
-    | (`C | `D) as ___bisect_matched_value___ ->
-        (match[@ocaml.warning "-4-8-9-11-26-27-28-33"]
-           ___bisect_matched_value___
-         with
-        | `C ->
-            ___bisect_visit___ 3;
-            ()
-        | `D ->
-            ___bisect_visit___ 4;
-            ()
-        | _ -> ());
-        ___bisect_post_visit___ 0 (assert false)
+    | `C | `D -> assert false
   $ dune build ./test.bc --instrument-with bisect_ppx