Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mingw support with cmake #87

Closed
wants to merge 15 commits into from
Closed

Fix mingw support with cmake #87

wants to merge 15 commits into from

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Jul 9, 2021

  • add CI github action building librw on msys2 with mingw.
  • allow linking with static/shared glfw3/SDL2 + change between them without having to modify paths in the cache.
  • statically link to the compiler runtime: on MINGW, this is useful to avoid needing libgcc.dll,libstdc++.dll or libwinpthread.dll.
  • add the processor architecture to the generated tar ball filename.
  • fix linking on mingw: mark WinMain as undefined, thus not throwing away the symbol from the librw_skeleton library.
  • set the default MSVC debugger working directory for each executable to its file location. This was useful for finding the assertion error in Bump imgui to 1.83 #86
  • fix linking with SDL2: add SDL_MAIN_HANDLED to avoid renaming main to SDL_main.
  • add the ability to install runtime libraries (libgcc.dll,libstdc++.dll or libwinpthread.dll) + glfw3/sdl2 dll library (only when needed).

@ccawley2011 Can you please review this one?

Overrides #83

CMakeLists.txt Outdated Show resolved Hide resolved
cmake/librw-config.cmake.in Outdated Show resolved Hide resolved
@madebr madebr force-pushed the cmake_mingw branch 2 times, most recently from cddb2f8 to 58b373f Compare July 9, 2021 10:33
@madebr
Copy link
Contributor Author

madebr commented Aug 31, 2021

Ready for review.

@madebr madebr closed this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants