Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LSP and the VSCode addon using it #239

Merged
merged 26 commits into from
Sep 22, 2023
Merged

Conversation

ewoudje
Copy link
Contributor

@ewoudje ewoudje commented Apr 18, 2023

The LSP implementation and the vscode extension that i have showcased before.
Its WIP still; but the first wave of recommendations/changes can be made already.

Both parts are written in typescript.

TODO:

  • Add experimental option and put --errors under it.
  • Conflict when parsing and writing the file at the same time.
  • Github workflow for testing lsp
  • Fix code needing manual modification before packaging
  • Update main docs on how to use the extension and its features
  • Add lobster icons
  • Add breakpoints via DAP (Finished kinda has debugging but no breakpoints, not gonna do this in this PR)

@ewoudje ewoudje marked this pull request as draft April 18, 2023 15:47
dev/lsp/src/document.ts Outdated Show resolved Hide resolved
dev/lsp/tsconfig.tsbuildinfo Outdated Show resolved Hide resolved
dev/src/lobster/parser.h Outdated Show resolved Hide resolved
docs/vscode/lobster/.eslintrc.js Outdated Show resolved Hide resolved
docs/vscode/lobster/.vscode/launch.json Show resolved Hide resolved
docs/vscode/lobster/package-lock.json Outdated Show resolved Hide resolved
docs/vscode/tasks.json Outdated Show resolved Hide resolved
@aardappel
Copy link
Owner

Need to update the main docs on how to install the extension.

Also, you moved the syntax highlighting file into the extension. Is this normal? I would expect that to function regardless of whether you are using an LSP.

@ewoudje
Copy link
Contributor Author

ewoudje commented Apr 18, 2023

Need to update the main docs on how to install the extension.

Also, you moved the syntax highlighting file into the extension. Is this normal? I would expect that to function regardless of whether you are using an LSP.

Well it was a very small extension, now I just made it a bigger extension that boots up a LSP.

@ewoudje
Copy link
Contributor Author

ewoudje commented Apr 18, 2023

With the latest commit it now includes a packaged file with the full extension which is very easy to install.

@ewoudje ewoudje marked this pull request as ready for review September 18, 2023 19:46
@ewoudje
Copy link
Contributor Author

ewoudje commented Sep 18, 2023

Im unsure if I should modify some READMEs to highlight the existence of a vscode extension?

Copy link
Owner

@aardappel aardappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! A bit more work on the docs and we can merge this :)

docs/source/lsp.md Outdated Show resolved Hide resolved
docs/source/vscode_ide.md Outdated Show resolved Hide resolved
docs/source/vscode_ide.md Outdated Show resolved Hide resolved
docs/source/vscode_ide.md Outdated Show resolved Hide resolved
docs/source/vscode_ide.md Outdated Show resolved Hide resolved
docs/source/vscode_ide.md Outdated Show resolved Hide resolved
@aardappel
Copy link
Owner

Awesome!

@aardappel aardappel merged commit e180511 into aardappel:master Sep 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants