Skip to content

Fix/unique token generation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fix/unique token generation #78

merged 3 commits into from
Nov 17, 2020

Conversation

aaronn
Copy link
Owner

@aaronn aaronn commented Nov 17, 2020

• Hopefully addresses #77

  • We now relax the unique constraint. This constraint wasn't great because there will eventually be many is_active=False entries with the same key– and this will throw an IntegrityError.
  • We now retry N times before throwing an ValidationError. this can be configured with the PASSWORDLESS_TOKEN_GENERATION_ATTEMPTS setting.

@aaronn
An update to how tokens are generated, as well as a removal of the un…
f0e1d1f 
…ique constraint to accomodate multiple false tokens of the same type.
@aaronn
Comments
705000c
@aaronn
Comments
5bec326
@aaronn aaronn merged commit 0a382e9 into master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aaronn