-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added text change width and shape of button #575
added text change width and shape of button #575
Conversation
I would like to request the following items |
For those am still testing on them, once comfortable will push ASAP |
@markarik Thanks a lot for your contribution here. Would this be fine to be merged by you? Or would you try to add any more properties to it? The PR looks good by me |
@markarik Thank you. the test is working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 'package-lock.json' unnecessary in PR?
Promise.resolve(this.locale).then((value) => { | ||
|
||
console.log("value", value); | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
degrades performance
<div class="card-block d-flex justify-content-center"> | ||
<asl-google-signin-button class="mx-1"></asl-google-signin-button> | ||
|
||
<asl-google-signin-button class="mx-5"></asl-google-signin-button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "mx-1" is better
Am humbled,, I think am not in a position to merge it |
Great thanks ,, I suppose on my laptop it just dint want to work at the moment |
I can merge it. What I meant was to ask if you intended to make any more commits to this PR. |
Yes you can merge it, I don't intend to add anything else |
From this link on Google Button Generator
there are attributes from the generated code which would be essential for this package to make it atlist customizable as much as possible
Below is a screenshot of the demo page after working on the attributes