Skip to content

Feature native sql #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Conversation

whothefluff
Copy link
Contributor

Feel free to add this app to the repo.

I made it both as a way to learn to use the library and to have something to be a naughty on my job. Now basis can't stop me lol

There are a couple of things that maybe you want to backport to the original app, mainly

  • the fact that the results pane was hanging in a weird way and didn't extend all the way to the bottom:
    image
    (I got rid of the grid and used a flexbox)

  • and the bug about not being able to filter/order directly on the table component:
    image
    These quotes shouldn't be there:
    image

Someday I'll also use cl_adt_dp_cds_assoc_osql_map to convert ABAP CDS associations into joins because they are not materialized in HDB for some reason

@oblomov-dev oblomov-dev merged commit e7991fc into abap2UI5-addons:main Oct 27, 2024
1 of 2 checks passed
@oblomov-dev
Copy link
Member

very cool, looks great! :)

the idea was to have some helper tools for developers, so native sql is a great idea, but yes better not tell the basis ;)

your bugfixes are good to know too, i think using a flexbox is the better approach, and i also overlooked the quotes, will bring it to the other console one day.

thanks a lot!

@whothefluff whothefluff deleted the feature-native-sql branch October 27, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants