Skip to content

Refactoring #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2024
Merged

Refactoring #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca58dae
refactoring
oblomov-dev May 1, 2024
defc197
refactoring
oblomov-dev May 1, 2024
874de44
refactoring
oblomov-dev May 1, 2024
5eab5c7
Update test_downport.yaml
oblomov-dev May 1, 2024
a0568bd
Update build_downport.yaml
oblomov-dev May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_downport.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: build_downport

on:
pull_request:
push:
branches: [main]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_downport.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: test_downport

on:
push:
pull_request:

permissions:
contents: read
Expand Down
14 changes: 7 additions & 7 deletions src/z2ui5_cl_demo_app_000.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,13 +642,6 @@
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Network Graph'
press = client->_event( 'z2ui5_cl_demo_app_182' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
expanded = abap_true
Expand Down Expand Up @@ -1323,6 +1316,13 @@
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Network Graph'
press = client->_event( 'z2ui5_cl_demo_app_182' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
expanded = abap_true
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_057.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS z2ui5_cl_demo_app_057 DEFINITION
PUBLIC SECTION.

INTERFACES z2ui5_if_app .
INTERFACES if_serializable_object .


TYPES:
BEGIN OF ty_s_tab,
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_064.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CREATE PUBLIC .

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_077.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_077 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_085.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS Z2UI5_CL_DEMO_APP_085 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES Z2UI5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_086.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS Z2UI5_CL_DEMO_APP_086 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES Z2UI5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_097.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS Z2UI5_CL_DEMO_APP_097 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES Z2UI5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_098.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS Z2UI5_CL_DEMO_APP_098 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_099.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_099 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_104.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS z2ui5_cl_demo_app_104 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA mo_app_sub TYPE REF TO object .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_105.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_105 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA client TYPE REF TO z2ui5_if_client .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_106.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Z2UI5_CL_DEMO_APP_106 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

data CHECK_INITIALIZED type ABAP_BOOL .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_107.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_107 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_108.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Z2UI5_CL_DEMO_APP_108 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

data:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_110.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_110 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA product TYPE string .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_111.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_111 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_112.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class z2ui5_cl_demo_app_112 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

data CLIENT type ref to Z2UI5_IF_CLIENT .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_118.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_118 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA check_initialized TYPE abap_bool .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_119.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_119 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA product TYPE string .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_129.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_129 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_130.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_140.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_140 DEFINITION
CREATE PUBLIC .

PUBLIC SECTION.
INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_142.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_142 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA check_initialized TYPE abap_bool .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_145.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Z2UI5_CL_DEMO_APP_145 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

data CHECK_INITIALIZED type ABAP_BOOL .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_146.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_146 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_148.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_148 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA ls_dataset TYPE z2ui5_cl_cc_chartjs=>ty_dataset.
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_161.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_161 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA client TYPE REF TO z2ui5_if_client .
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_163.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Z2UI5_CL_DEMO_APP_163 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

PROTECTED SECTION.
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_178.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CLASS z2ui5_cl_demo_app_178 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES:
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_180.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_180 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA mv_initialized TYPE abap_bool.
Expand Down
4 changes: 2 additions & 2 deletions src/z2ui5_cl_demo_app_181.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_181 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

DATA mv_initialized TYPE abap_bool .
Expand Down Expand Up @@ -62,7 +62,7 @@ CLASS Z2UI5_CL_DEMO_APP_181 IMPLEMENTATION.

DATA(view) = z2ui5_cl_xml_view=>factory( ).

data(page) = view->page(
data(page) = view->shell( )->page(
title = `Cards Demo`
class = `sapUiContentPadding`
navbuttonpress = client->_event( 'BACK' )
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_182.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLASS z2ui5_cl_demo_app_182 DEFINITION

PUBLIC SECTION.

INTERFACES if_serializable_object .

INTERFACES z2ui5_if_app .

TYPES: BEGIN OF t_attributes3,
Expand Down
2 changes: 1 addition & 1 deletion src/z2ui5_cl_demo_app_186.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class Z2UI5_CL_DEMO_APP_186 definition

public section.

interfaces IF_SERIALIZABLE_OBJECT .

interfaces Z2UI5_IF_APP .

data IS_INITIALIZED type BOOLEAN .
Expand Down