Skip to content

Add eslint guidelines #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add eslint guidelines #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/development-guide/read-first/guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ Pull requests must pass all abaplint configured checks before they can be merged
You can view abaplint findings directly in abapGit using an [extension](https://github.com/Marc-Bernard-Tools/ABAP-Lint-Ext-for-abapGit).
:::

### eslint

JavaScript is checked using eslint. You can find the rules [here](https://github.com/abapGit/abapGit/blob/main/.eslintrc.yaml). All JavaScript code has to adhere to ES5 ([ECMAScript 2009](https://en.wikipedia.org/wiki/ECMAScript_version_history)) to be compatible with the IE-based HTML browser control used in older releases of SAP GUI.

### Internationalization (I18N)

abapGit supports only the English language. Neither objects nor text literals are translated. Therefore, all objects shall be set to English as the original language, and text literals in the code shall be maintained in English.
Expand Down