Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log info if value is not found. #103

Closed
sailorlqh opened this issue May 23, 2023 · 1 comment
Closed

Add log info if value is not found. #103

sailorlqh opened this issue May 23, 2023 · 1 comment
Assignees
@qiaoweiz
Labels
good first issue Good for newcomers

Comments

@sailorlqh
Copy link
Contributor

Context: https://github.com/abcxyz/pmap/blob/main/pkg/server/event_handler.go#L342-L364
@sailorlqh sailorlqh self-assigned this May 23, 2023
@sailorlqh sailorlqh mentioned this issue May 23, 2023
Merged
@yolocs yolocs added the good first issue Good for newcomers label May 25, 2023
@dandans-verily dandans-verily assigned qiaoweiz and unassigned qiaoweiz and sailorlqh Jun 23, 2023
@qiaoweiz qiaoweiz mentioned this issue Jun 26, 2023
Merged
@qiaoweiz
Copy link
Contributor

Context: https://github.com/abcxyz/pmap/blob/main/pkg/server/event_handler.go#L342-L364

Hi @sailorlqh , I want to double check with the requirement.
do you only want to log when the value is not found?
or to log error and return nil (follow the same path as https://screenshot.googleplex.com/JYW5jdoDpqD3HwZ)?

qiaoweiz added a commit that referenced this issue Jun 27, 2023
@qiaoweiz
[#103] Add log info if value is not found (#135)
5b24e38 
* logger

* Add log info if value is not found.

* remove unused logger

* Revert changes about error return

* Update log info & add a test about githubSource not found

* update test name & info log

* Add a comment for unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaoweiz qiaoweiz

Labels
good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yolocs @capri-xiyue @sailorlqh @qiaoweiz