Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103] Add log info if value is not found #135

Merged
merged 7 commits into from
Jun 27, 2023
Merged

[#103] Add log info if value is not found #135

merged 7 commits into from
Jun 27, 2023

Conversation

qiaoweiz
Copy link
Contributor

Add log info if value for MetadataKeyGitHubCommit, MetadataKeyGitHubRepo, MetadataKeyWorkflow, MetadataKeyWorkflowSha is not found.

Link to issue: #103

@qiaoweiz qiaoweiz requested a review from a team as a code owner June 26, 2023 22:48
@qiaoweiz qiaoweiz requested review from sqin2019 and ruizhg June 26, 2023 22:48
@dandans-verily dandans-verily requested review from capri-xiyue and sailorlqh and removed request for sqin2019 and ruizhg June 26, 2023 22:51
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler.go Outdated Show resolved Hide resolved
pkg/server/event_handler_test.go Show resolved Hide resolved
sailorlqh
sailorlqh previously approved these changes Jun 27, 2023
Copy link
Contributor

@sailorlqh sailorlqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's wait for Xiyue's opinion before merging.

@qiaoweiz qiaoweiz merged commit 5b24e38 into main Jun 27, 2023
@qiaoweiz qiaoweiz deleted the log/debug branch June 27, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants