Fix: Update tf vars #147
Merged
Fix: Update tf vars #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailorlqh
force-pushed
the
sailorlqh/update_service_tf
branch
from
edfa649
to
2f2cf8a
Compare
sailorlqh
force-pushed
the
sailorlqh/update_service_tf
branch
from
b7b0abe
to
a1c974e
Compare
|
/Ready for review. |
sailorlqh
force-pushed
the
sailorlqh/update_service_tf
branch
from
a1c974e
to
b607d12
Compare
sailorlqh
force-pushed
the
sailorlqh/update_service_tf
branch
from
b607d12
to
146aa7e
Compare
capri-xiyue
reviewed
Jul 11, 2023
capri-xiyue
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a better way to have
defaultResourceScopeset only for mapping service.By doing this,
PMAP_MAPPING_DEFAULT_RESOURCE_SCOPEwon't appear in policy service's env vars, and we don't need to defaultvar.pmap_mapping_default_resource_scopeand parse it toproject/project-idfor mapping service.Also, using
extra_container_env_vars(maybe a better naming can be discussed later), we can customize different env vars for different services.There are some other cases for using
merge()to setup env vars interraform-modulerepo. So I think this might be a good approach.I want to get some input from you before I convert this draft PR into ready for review.