Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add e2e test converage to test pmap customized scope #142

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: add e2e test converage to test pmap customized scope #142

merged 2 commits into from
Jul 12, 2023

Conversation

sailorlqh
Copy link
Contributor

fix: #141

@sailorlqh sailorlqh marked this pull request as ready for review July 10, 2023 20:14
@sailorlqh sailorlqh requested a review from a team as a code owner July 10, 2023 20:15
@sailorlqh sailorlqh requested review from verbanicm, yolocs, sqin2019 and capri-xiyue and removed request for verbanicm July 10, 2023 20:15
capri-xiyue
capri-xiyue previously approved these changes Jul 10, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
capri-xiyue
capri-xiyue reviewed Jul 10, 2023
View reviewed changes
test/integration/main_test.go Outdated Show resolved Hide resolved
test/integration/main_test.go Outdated Show resolved Hide resolved
@sailorlqh
Copy link
Contributor Author

sailorlqh commented Jul 10, 2023 •
edited
Loading

/Hold until PR#147 and PR#148 for creating static resources is merged and applied.

@sailorlqh sailorlqh mentioned this pull request Jul 11, 2023
Closed
@sailorlqh sailorlqh force-pushed the sailorlqh/test_scope_e2e branch 2 times, most recently from 4e78845 to cfe3295 Compare July 12, 2023 20:25
capri-xiyue
capri-xiyue previously approved these changes Jul 12, 2023
View reviewed changes
@sailorlqh sailorlqh merged commit 23528db into main Jul 12, 2023
@sailorlqh sailorlqh deleted the sailorlqh/test_scope_e2e branch July 12, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolocs yolocs yolocs approved these changes

@capri-xiyue capri-xiyue capri-xiyue approved these changes

@sqin2019 sqin2019 Awaiting requested review from sqin2019

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integ test case on getting GCS bucket info from other project (pmap-dev)
4 participants
@sailorlqh @yolocs @sqin2019 @capri-xiyue