Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create static scoped non-GCS bucket resource (AR repo) in CI for integration test #148

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

sailorlqh
Copy link
Contributor

Create a artifact registry repo as a static scoped non-GCS bucket resource in CI for integration test.

@sailorlqh sailorlqh force-pushed the sailorlqh/create_static_non_GCS_resource branch from 52a1209 to 63ba087 Compare July 11, 2023 22:27
@sailorlqh sailorlqh marked this pull request as ready for review July 12, 2023 00:54
@sailorlqh sailorlqh requested a review from a team as a code owner July 12, 2023 00:54
Copy link
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this again?

@capri-xiyue
Copy link
Contributor

Why we need this again?

We need one non-gcs bucket resource to test the scope parsing logic work

@sailorlqh sailorlqh merged commit fc8bb32 into main Jul 12, 2023
@sailorlqh sailorlqh deleted the sailorlqh/create_static_non_GCS_resource branch July 12, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants