Skip to content

Fix network error in Chrome caused by large blobs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2018
Merged

Fix network error in Chrome caused by large blobs #73

merged 4 commits into from
Mar 7, 2018

Conversation

mriccid
Copy link
Collaborator

@mriccid mriccid commented Mar 6, 2018

Fixes #44
Fixes #62

@mriccid mriccid self-assigned this Mar 6, 2018
@mriccid mriccid requested a review from abdennour March 6, 2018 23:17
@mriccid mriccid changed the title Fix network error in Chrome caused by large blobs Fix network error in Chrome caused by large blobs (WIP) Mar 6, 2018
@mriccid mriccid mentioned this pull request Mar 6, 2018
Closed
@mriccid mriccid changed the title Fix network error in Chrome caused by large blobs (WIP) Fix network error in Chrome caused by large blobs Mar 7, 2018
@coveralls
Copy link

coveralls commented Mar 7, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 94.805% when pulling 37a5de7 on fix/network-error-chrome into 7bee65a on master.

@mriccid mriccid added the fix label Mar 7, 2018
abdennour
abdennour approved these changes Mar 7, 2018
View reviewed changes
Copy link
Collaborator

@abdennour abdennour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope users of this library pay attention to the compatibility of Blob with mobile devices

@mriccid mriccid merged commit 7ef9959 into master Mar 7, 2018
@mriccid mriccid deleted the fix/network-error-chrome branch March 7, 2018 22:53
@clarali210 clarali210 mentioned this pull request Mar 7, 2018
Closed
@clarali210
Copy link

Thank you!!

@mccabemj mccabemj mentioned this pull request Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdennour abdennour abdennour approved these changes

Assignees

@mriccid mriccid

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mriccid @coveralls @clarali210 @abdennour