Skip to content

Fix network error in Chrome caused by large blobs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2018
Merged

Fix network error in Chrome caused by large blobs #73

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ede205d
Use URL.createObjectURL to handle large blob sizes causing network er…
Mar 6, 2018
6b1803d
Add WIP/tasks
Mar 6, 2018
2532dfd
Handle lack of support for createObjectURL
Mar 7, 2018
37a5de7
Rewrite function to increase test coverage
Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,14 @@ export const toCSV = (data, headers, separator) => {
throw new TypeError(`Data should be a "String", "Array of arrays" OR "Array of objects" `);
};

export const buildURI = ((data, uFEFF, headers, separator) => encodeURI(
`data:text/csv;charset=utf-8,${uFEFF ? '\uFEFF' : ''}${toCSV(data, headers, separator)}`
)
);
export const buildURI = ((data, uFEFF, headers, separator) => {
const csv = toCSV(data, headers, separator);
const blob = new Blob([uFEFF ? '\uFEFF' : '', csv], {type: 'text/csv'});
const dataURI = `data:text/csv;charset=utf-8,${uFEFF ? '\uFEFF' : ''}${csv}`;

const URL = window.URL || window.webkitURL;

return (typeof URL.createObjectURL === 'undefined')
? dataURI
: URL.createObjectURL(blob);
});