Dockerizing OpenSTA #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should use cmake instead of autotools, since the autotools is likely to
disappear soon
…On Wednesday, January 9, 2019, Abdelrahman ***@***.***> wrote:
This pull request proposes packaging OpenSTA in a Docker image. Users
don't have to run through lengthy and buggy installation steps. The Docker
image is available on Docker Hub (openroad/opensta).
After installing Docker, run OpenSTA using docker run -it -v
$(pwd):/input openroad/opensta where -v $(pwd):/input mounts the current
directory to a directory inside the Docker container called input, where
the input files reside.
------------------------------
You can view, comment on, or merge this pull request online at:
#14
Commit Summary
- dockerizing OpenSTA
File Changes
- *A* Dockerfile
<https://github.com/abk-openroad/OpenSTA/pull/14/files#diff-0> (30)
Patch Links:
- https://github.com/abk-openroad/OpenSTA/pull/14.patch
- https://github.com/abk-openroad/OpenSTA/pull/14.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#14>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8lRD2Zuk_kge-VV8ea0iaGhgK79dVks5vBn-MgaJpZM4Z4hVJ>
.
|
|
It is also broken because it pulls from your private repo instead of the
github repo.
…On Thursday, January 10, 2019, James Cherry ***@***.***> wrote:
you should use cmake instead of autotools, since the autotools is likely
to disappear soon
On Wednesday, January 9, 2019, Abdelrahman ***@***.***>
wrote:
> This pull request proposes packaging OpenSTA in a Docker image. Users
> don't have to run through lengthy and buggy installation steps. The Docker
> image is available on Docker Hub (openroad/opensta).
>
> After installing Docker, run OpenSTA using docker run -it -v
> $(pwd):/input openroad/opensta where -v $(pwd):/input mounts the current
> directory to a directory inside the Docker container called input, where
> the input files reside.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #14
> Commit Summary
>
> - dockerizing OpenSTA
>
> File Changes
>
> - *A* Dockerfile
> <https://github.com/abk-openroad/OpenSTA/pull/14/files#diff-0> (30)
>
> Patch Links:
>
> - https://github.com/abk-openroad/OpenSTA/pull/14.patch
> - https://github.com/abk-openroad/OpenSTA/pull/14.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#14>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AhI8lRD2Zuk_kge-VV8ea0iaGhgK79dVks5vBn-MgaJpZM4Z4hVJ>
> .
>
|
|
I'm working on another version now that:
|
|
When I build CUDD I don't use any configure args.
I don't bother with 'make check'.
I don't see 'make install' for the results; make a cudd dir someplace and
set path prefix there
and point the sta build to it. Like this:
cd $HOME/cudd-3.0.0
mkdir $HOME/cudd
./configure --prefix $HOME/cudd
make
and then for OpenSTA
build .. -DCUDD=$HOME/cudd
…On Wednesday, January 16, 2019, Abdelrahman ***@***.***> wrote:
I'm working on another version now that:
1. Uses dockerfile COPY command to add files from the repo. This will
help make versions of the Docker image according to releases on the repo
here.
2. Uses cmake instead of autoconf. It's just taking some time as there
are errors when including cudd.h which I'm still trying to solve.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8lavsjITh-1h6qU8uXRM3JuJeLwPBks5vD259gaJpZM4Z4hVJ>
.
|
|
try again
cd $HOME/cudd-3.0.0
mkdir $HOME/cudd
./configure --prefix $HOME/cudd
make
make install
and then for OpenSTA
cmake .. -DCUDD=$HOME/cudd
Reply
Forward
…On Wednesday, January 16, 2019, James Cherry ***@***.***> wrote:
When I build CUDD I don't use any configure args.
I don't bother with 'make check'.
I don't see 'make install' for the results; make a cudd dir someplace and
set path prefix there
and point the sta build to it. Like this:
cd $HOME/cudd-3.0.0
mkdir $HOME/cudd
./configure --prefix $HOME/cudd
make
and then for OpenSTA
build .. -DCUDD=$HOME/cudd
On Wednesday, January 16, 2019, Abdelrahman ***@***.***>
wrote:
> I'm working on another version now that:
>
> 1. Uses dockerfile COPY command to add files from the repo. This will
> help make versions of the Docker image according to releases on the repo
> here.
> 2. Uses cmake instead of autoconf. It's just taking some time as
> there are errors when including cudd.h which I'm still trying to
> solve.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#14 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AhI8lavsjITh-1h6qU8uXRM3JuJeLwPBks5vD259gaJpZM4Z4hVJ>
> .
>
|
|
I pushed an update that has a Dockerfile based on yours that successfully
builds OpenSTA.
I have never used docker before and don't see how to actually run the image.
I think it should use ENTRYPOINT instead of CMD to pass the sta command
file in as
an arg to docker run but it doesn't seem to work properly. It looks like
stdout goes off
to never never land.
…On Wednesday, January 16, 2019, James Cherry ***@***.***> wrote:
try again
cd $HOME/cudd-3.0.0
mkdir $HOME/cudd
./configure --prefix $HOME/cudd
make
make install
and then for OpenSTA
cmake .. -DCUDD=$HOME/cudd
Reply
Forward
On Wednesday, January 16, 2019, James Cherry ***@***.***>
wrote:
> When I build CUDD I don't use any configure args.
> I don't bother with 'make check'.
> I don't see 'make install' for the results; make a cudd dir someplace and
> set path prefix there
> and point the sta build to it. Like this:
>
> cd $HOME/cudd-3.0.0
> mkdir $HOME/cudd
> ./configure --prefix $HOME/cudd
> make
>
> and then for OpenSTA
> build .. -DCUDD=$HOME/cudd
>
>
> On Wednesday, January 16, 2019, Abdelrahman ***@***.***>
> wrote:
>
>> I'm working on another version now that:
>>
>> 1. Uses dockerfile COPY command to add files from the repo. This
>> will help make versions of the Docker image according to releases on the
>> repo here.
>> 2. Uses cmake instead of autoconf. It's just taking some time as
>> there are errors when including cudd.h which I'm still trying to
>> solve.
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <#14 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AhI8lavsjITh-1h6qU8uXRM3JuJeLwPBks5vD259gaJpZM4Z4hVJ>
>> .
>>
>
|
|
Ok. I'm going to rebase my branch on this repo branch and edit the Docker file accordingly. |
|
So, I polished the Dockerfile and updated the README file to point users to how to run the Docker image. I also pushed an image of OpenSTA to Docker Hub at https://hub.docker.com/r/openroad/opensta |
|
that link 404'd for me
…On Thursday, January 17, 2019, Abdelrahman ***@***.***> wrote:
So, I polished the Dockerfile and updated the README file to point users
to how to run the Docker image. I also pushed an image of OpenSTA to Docker
Hub at https://cloud.docker.com/u/openroad/repository/docker/
openroad/opensta
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8ldzn9S4TGHToA26J8dEkxwcOeWd0ks5vEPmMgaJpZM4Z4hVJ>
.
|
|
I updated the link. Here it is: https://hub.docker.com/r/openroad/opensta |
|
I got it to run as advertised.
One small nit; the run command arg -it should be -i for interactive in
README
…On Thursday, January 17, 2019, Abdelrahman ***@***.***> wrote:
I updated the link. Here it is: https://hub.docker.com/r/openroad/opensta
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8lSVQ5l69Jq2EEYojKOf3WubVmVtYks5vEXyfgaJpZM4Z4hVJ>
.
|
|
According to the official Docker documentation, it says: I know it works with only |
|
got it. thanks.
…On Friday, January 18, 2019, Abdelrahman ***@***.***> wrote:
According to the official Docker documentation
<https://docs.docker.com/engine/reference/run/#foreground>, it says:
For interactive processes (like a shell), you must use -i -t together in
order to allocate a tty for the container process. -i -t is often written
-it as you’ll see in later examples.
I know it works with only -i flag, but it doesn't show the % sign for the
beginning of writing the command. I am not sure what other side effect we
might have leaving out the -t flag.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8lTv-2BjScVGyDmDyhPg_ZZc4O3tsks5vEh8wgaJpZM4Z4hVJ>
.
|
|
Hi James, |
|
I don't feel comfortable with the README being so docker centric.
I think that INSTALL may be a better home for it.
The README.md line that has RSPF/DSPF/SPEF should be updated to SPEF to
stay in sync with a recent README edit.
…On Friday, January 18, 2019, Abdelrahman ***@***.***> wrote:
Hi James,
Is there any more work to be done on this pull request in order to be
merged and closed? :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhI8leSqclQl5qETPlF-hehH6oHUi5Zqks5vErLogaJpZM4Z4hVJ>
.
|
|
So, can you confirm the following changes to be committed to this merge request?
|
|
I guess I hadn't pushed it. You should see it now. |
zekungao
pushed a commit
to zekungao/OpenSTA
that referenced
this pull request
Aug 2, 2023
* add header files needed by other prj * dont use cells should have eq cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes packaging OpenSTA in a Docker image. Users don't have to run through lengthy and buggy installation steps. The Docker image is available on Docker Hub (
openroad/opensta).After installing Docker, run OpenSTA using
docker run -it -v $(pwd):/input openroad/openstawhere-v $(pwd):/inputmounts the current directory to a directory inside the Docker container calledinput, where the input files reside.