Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-4803] StatusPage component #430

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

kennethkalmer
Copy link
Member

@kennethkalmer kennethkalmer commented Jul 24, 2024

Jira Ticket Link / Motivation

Supersedes #421 by replacing the embedded status icon from ably.com/status/embed/icon with a React component that fetches the status from the statuspage.io API for us

Summary of changes

  • New Status component, requires the statusUrl to be set to work reliably
  • Added stories for the Status component so we view the different states
  • Replaced the iframe in the Footer and Meganav components with the Status

See commits for details

How do you manually test this?

Pull, run storybook, and view the Status components

Reviewer Tasks (optional)

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

@kennethkalmer kennethkalmer requested review from jamiehenson and aralovelace and removed request for jamiehenson July 24, 2024 09:11
@kennethkalmer kennethkalmer self-assigned this Jul 24, 2024
Copy link
Member

@jamiehenson jamiehenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a couple of things, can we also bump the package.json version to 14.2.0?

src/core/Status.tsx Outdated Show resolved Hide resolved
src/core/Status.tsx Outdated Show resolved Hide resolved
src/core/Status/Status.stories.tsx Show resolved Hide resolved
Pulls our status from StatusPage.io and renders a coloured dot based on
the status indicator. Also refreshes every minute to keep pages up to
date
Copy link
Member

@jamiehenson jamiehenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛥️

@kennethkalmer kennethkalmer merged commit 575ed66 into main Jul 24, 2024
3 checks passed
@kennethkalmer kennethkalmer deleted the INF-4803-statuspage-component branch July 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants