Handle podspec file #2

rpotter12 · 2020-07-15T05:18:15Z

add code to handle podspec file.
update scripts to detect all types of dependencies from the file.

steven-esser

@rpotter12 Are the various formatting changes done by you or by some formatter tool?

Also, we probably want to Add or Update the README file to explain the reason for the fork and what exactly is different than gemfileparser

rpotter12 · 2020-07-16T04:41:37Z

@rpotter12 Are the various formatting changes done by you or by some formatter tool?

@MaJuRG All the formatting changes are done by me only. :)

Also, we probably want to Add or Update the README file to explain the reason for the fork and what exactly is different than gemfileparser

Okay. I will update the README file soon :)

steven-esser

@rpotter12 Since we fork, I am not sure we want to have stuff like syntax changes. I think in general, formatting changes like this are a good thing. I am more concerned about having a clean diff in case we want to merge this in upstream in the future.

@pombredanne What is your take here?

@rpotter12 Other than that particular minor issue, this looks good to me.

pombredanne

Thank you! I only have a few nits for your review... but most and foremost we need to have tests for these before we can merge.

pombredanne · 2020-07-21T13:24:44Z

gemfileparser/__init__.py


        def __init__(self):
-            self.name = None
+            self.name = ''


Why use empty strings instead of None?

I think the repo which we have forked is some commits behind. Using empty strings here are the original changes in the upstream repo. And may be this is helpful in extracting data from gemfile files.

pombredanne · 2020-07-21T13:35:54Z

gemfileparser/__init__.py

-            self.group = None
-            self.platform = None
-            self.platforms = []
-            self.groups = []


I guess you removed these attributes because they are either not in the spec or seldom used or parsable?
platform is still a thing though rarely there alright https://guides.rubygems.org/specification-reference/#platform=
Can you confirm?

I never saw a group in a spec so far... did you?

I think they are used in gemfile files. gemfileparser is for both gemspec and gemfile but I think @balankarc have implement these in another way so he removed this in the original repository :)

pombredanne · 2020-07-21T13:39:25Z

gemfileparser/__init__.py

    def parse_line(self, line):
-        '''Parses each line and creates dependency objects accordingly'''
+        """
+        Parses each line and creates dependency objects accordingly.


Please use the imperative style for docstrings.

I will change it soon :)

pombredanne · 2020-07-21T13:41:20Z

gemfileparser/__init__.py

-            dep.parent = []
-        else:
+        linefile = io.StringIO(line)    # csv requires a file object
+        for line in csv.reader(linefile, delimiter=','):


Can you remind my the benefits of using a CSV module here?

I think @balasankarc used this CSV module here because dependency contains name and different version numbers and they are seperated by comma and they have to split by comma and if we use something else then to remove extra character the code will become more complex. CSV module might have make this easy to remove extra characters. I guess this might be the only good solution to use CSV module here.

pombredanne · 2020-07-21T13:46:25Z

setup.py

-    'download_url': 'https://gitlab.com/balasankarc/gemfileparser',
-    'author_email': 'balasankarc@autistici.org',
+    'description': "A library to parse Rubygem gemspec and Gemfile files and Cocoapods podspec and Podfile files using Python. Friendly fork of https://gitlab.com/balasankarc/gemfileparser",
+    'author': 'nexB',


Please keep the original author name there. Or something like `Rohit Potter for nexB based on original work of Balasankar C' ... but in all cases we want Balasankar to get proper credits

Okh :)
I will change this in new commits.

In case we get to collaborate and move development upstream as suggested in #2 (comment), this can definitely change to an AUTHOR file based logic so that every contributor gets credit. 🙂

pombredanne · 2020-07-24T13:13:06Z

Never mind the auto close.... that's Github playing tricks on us.

balasankarc · 2020-07-24T18:50:32Z

@pombredanne @rpotter12 Wanted to open an issue about this, but since issue tracker is not enabled here I am "hijacking" this thread. 😀 Sorry about that.

If you are interested, I am more than happy to move gemfileparser into an organization and add you to it, so instead of maintaining a fork you can use the upstream repository itself. I am not sure about how much time I might be able to dedicate in maintaining it though, but if the project is of use to you, I think it is only right that you get to be an upstream contributors/co-authors.

rpotter12 · 2020-07-24T20:42:24Z

@balasankarc Thank you for your reply :)
gemfileparser is very helpful in the scancode-toolkit software. I think you can transfer ownership to @pombredanne or make us maintainer of that repo if you are not able to dedicate much time on it. We also need to update the Pypi version also because it is having the very old version gemfileparser and needs to be updated regularly.

Thank you so much for you reply :)

pombredanne · 2020-07-24T21:56:54Z

@balasankarc re

if you are interested, I am more than happy to move gemfileparser into an organization and add you to it, so instead of maintaining a fork you can use the upstream repository itself. I am not sure about how much time I might be able to dedicate in maintaining it though, but if the project is of use to you, I think it is only right that you get to be an upstream contributors/co-authors.

That would be great!

We can either create a new org or we can host it under nexB org as this is meant for use directly in https://github.com/nexB/scancode-toolkit which is in the same org. (ScanCode is a tool that you should consider for use in Gitlab ... even if this is Python and not Ruby as this is the best tool out there for license detection ;)

Note that I would like also to fold in that gemfileparser library the support we have for Gemfile.lock in here https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/gemfile_lock.py

So your call in anycase.
AFAIK the latest code is in your gitlab repo and not in Github ;).

balasankarc · 2020-07-25T06:39:40Z

Moved upstream to https://github.com/gemfileparser/gemfileparser
Synced GitHub with GitLab. Now both of them should have same code.
Added @pombredanne as an owner to https://github.com/gemfileparser so the needful can be done without depending on me.

@pombredanne If you have a PyPi profile, please share your email address and I can add you as a Maintainer to the package there too so you can update the package.

I will update README and add an AUTHOR file and everything in upstream repo soon.

pombredanne · 2020-07-25T06:50:28Z

@balasankarc you wrote:

Moved upstream to https://github.com/gemfileparser/gemfileparser Synced GitHub with GitLab. Now both of them should have same code. Added @pombredanne as an owner to https://github.com/gemfileparser so the needful can be done without depending on me. @pombredanne If you have a PyPi profile, please share your email address and I can add you as a Maintainer to the package there too so you can update the package. I will update README and add an AUTHOR file and everything in upstream repo soon.

That's great! Thank you: I am pombredanne @ PyPI too. @rpotter12 can you move your PR to https://github.com/gemfileparser/gemfileparser then?

…

-- Cordially Philippe Ombredanne

pombredanne · 2022-09-08T16:49:10Z

Closing these as we eventually used and pushed all these upstream!

* Add PEP 517/518 pyproject.toml file * Add setuptools_scm to handle versioning * Add setup.py content to setup.cfg * Update setup.py to act as a shim (so pip install -e works) Addresses: #2 Signed-off-by: Steven Esser <sesser@nexb.com>

rpotter12 added 3 commits July 15, 2020 10:44

update info

cfdf3d1

add code to handle podspec files

f6d96da

remove nose install require

71f4f6f

steven-esser suggested changes Jul 15, 2020

View reviewed changes

update README to specify changes

2e05a76

rpotter12 requested a review from steven-esser July 16, 2020 05:12

steven-esser approved these changes Jul 16, 2020

View reviewed changes

pombredanne requested changes Jul 21, 2020

View reviewed changes

pombredanne closed this Jul 24, 2020

pombredanne reopened this Jul 25, 2020

pombredanne closed this Sep 8, 2022

Uh oh!

Handle podspec file #2

Handle podspec file #2

Uh oh!

Conversation

rpotter12 commented Jul 15, 2020

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

rpotter12 commented Jul 16, 2020

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpotter12 Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pombredanne commented Jul 24, 2020

Uh oh!

balasankarc commented Jul 24, 2020

Uh oh!

rpotter12 commented Jul 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pombredanne commented Jul 24, 2020

Uh oh!

balasankarc commented Jul 25, 2020

Uh oh!

pombredanne commented Jul 25, 2020 via email

Uh oh!

pombredanne commented Sep 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rpotter12 Jul 21, 2020 •

edited

Loading

rpotter12 commented Jul 24, 2020 •

edited

Loading