Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception thrown when local disk is full #77

Closed
dleslie opened this issue Jul 21, 2018 · 7 comments
Closed

Exception thrown when local disk is full #77

dleslie opened this issue Jul 21, 2018 · 7 comments
Assignees
@abraunegg
Labels
Bug Something isn't working Fixed

Comments

@dleslie
Copy link

dleslie commented Jul 21, 2018 •
edited by abraunegg
Loading

Bug Report Details

Exception thrown when local disk is full
When the disk fills the following exception is thrown:

Jul 21 08:54:32 dleslie-ThinkPad-X140e onedrive[7651]: sqlite.SqliteException@src/sqlite.d(77): unable to open database file
Jul 21 08:54:32 dleslie-ThinkPad-X140e onedrive[7651]: ----------------
Jul 21 08:54:32 dleslie-ThinkPad-X140e onedrive[7651]: ??:? int sqlite.Database.getVersion() [0x14857181]
Jul 21 08:54:32 dleslie-ThinkPad-X140e onedrive[7651]: ??:? itemdb.ItemDatabase itemdb.ItemDatabase.__ctor(const(char)[]) [0x1483b6e0]
Jul 21 08:54:32 dleslie-ThinkPad-X140e onedrive[7651]: ??:? _Dmain [0x14840a6c]
Jul 21 08:54:32 dleslie-ThinkPad-X140e systemd[2236]: onedrive.service: Main process exited, code=exited, status=1/FAILURE
Jul 21 08:54:32 dleslie-ThinkPad-X140e systemd[2236]: onedrive.service: Failed with result 'exit-code'.
Jul 21 08:54:35 dleslie-ThinkPad-X140e systemd[2236]: onedrive.service: Service hold-off time over, scheduling restart.
Jul 21 08:54:35 dleslie-ThinkPad-X140e systemd[2236]: onedrive.service: Scheduled restart job, restart counter is at 2809.

Application and Operating System Details:

  • OS: Linux dleslie-ThinkPad-X140e 4.15.0-23-generic Make fail #25-Ubuntu SMP Wed May 23 18:02:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
  • Application version: v1.1.2-37-g4667eca

To Reproduce
Steps to reproduce the behavior if not causing an application crash:

  1. Launch onedrive service
  2. Fill the disk while the service is syncing
  3. See exception.
@abraunegg
Copy link
Owner

abraunegg commented Jul 21, 2018 •
edited
Loading

Thanks for the bug report. Will look into this issue and resolve to better handle the case of the local disk being full - it should exit gracefully rather than crash,

Additionally, your not running the latest version of the client which contains a number of fixes since the v1.1.2 release.

@abraunegg abraunegg added Bug Something isn't working Investigating labels Jul 21, 2018
@abraunegg abraunegg changed the title Exception thrown when Disk Full Exception thrown when local disk is full Jul 22, 2018
@abraunegg abraunegg self-assigned this Jul 22, 2018
abraunegg added a commit that referenced this issue Jul 23, 2018
@abraunegg
Implement better handling of database errors & issues
deabc0d 
* Implement better handling of database exit scenarios when there is zero disk space left on drive where the items database resides (Issue #77)
* Implement better handling of incorrect database permissions
* Implement better handling of different database versions to automatically re-create tables if version mis-match (RHBZ #1598934)
@abraunegg abraunegg mentioned this issue Jul 23, 2018
Merged
@abraunegg
Copy link
Owner

@dleslie
Can you please help validate PR #80 to resolve your issue please:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/80/head:pr80
git checkout pr80
make
make install

abraunegg added a commit that referenced this issue Jul 24, 2018
@abraunegg
Update patch for issue #77
0a848a0 
* Update logging to use log.error & log.log where relevant
* Dont pass dbVersion to createTable
@abraunegg
Copy link
Owner

@dleslie
Can you provide an update here as if your able to test the fix for your issue?

@abraunegg
Copy link
Owner

@dleslie
Can you provide an update here as if your able to test the fix for your issue?

@abraunegg
Copy link
Owner

Closed due to zero response from @dleslie

Will merge PR as local testing validated fix & code reviewed.

abraunegg added a commit that referenced this issue Aug 1, 2018
@abraunegg
Implement better handling of database errors & database disk space is…
aa995eb 
…sues (Issue #77) (#80)

* Implement better handling of database exit scenarios when there is zero disk space left on drive where the items database resides (Issue #77)
* Implement better handling of incorrect database permissions
* Implement better handling of different database versions to automatically re-create tables if version mis-match (RHBZ #1598934)
@dleslie
Copy link
Author

dleslie commented Aug 25, 2018

Yep, I believe this works now. Thanks! 👍

@lock
Copy link

lock bot commented Jan 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abraunegg abraunegg

Labels
Bug Something isn't working Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dleslie @abraunegg