Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download progress bar doesn't always reach 100% when rate_limit is set #2056

Merged
merged 16 commits into from
Jul 28, 2022
Merged

Fix download progress bar doesn't always reach 100% when rate_limit is set #2056

merged 16 commits into from
Jul 28, 2022

Conversation

abraunegg
Copy link
Owner

  • Add debugging for Manjaro curl HTTP/2 issue

@abraunegg
Add debugging for Manjaro curl HTTP/2 issue
e374ace 
* Add debugging for Manjaro curl HTTP/2 issue
@abraunegg
Update onedrive.d
b4ebfa6 
* Update PR
@abraunegg
Update onedrive.d
535faea 
* Update PR
@abraunegg
Update onedrive.d
43de3c4 
* Update PR
@abraunegg
Update onedrive.d
48a4e60 
* Update PR
@abraunegg
Update onedrive.d
fd1040b 
* Update PR
@abraunegg
Update onedrive.d
3ecc2fd 
* Update PR
@abraunegg
Update onedrive.d
f45326a 
* Update PR
@abraunegg
Update onedrive.d
a121223 
* Update PR
@abraunegg abraunegg changed the title Add debugging for Manjaro curl HTTP/2 issue Fix download progress bar doesn't always reach 100% when rate_limit is set Jul 26, 2022
@abraunegg
Copy link
Owner Author

abraunegg commented Jul 26, 2022 •
edited
Loading

Some testing.

Current Master + rate_limit = "524288"

Downloading file random_large_data/50mb.file ... 
Downloading  80% |oooooooooooooooooooooooooooooooo        |   ETA   00:00:24                                                                                                                      
done.
Downloading file random_large_data/100mb.file ... 
Downloading 100% |oooooooooooooooooooooooooooooooooooooooo| DONE IN 00:03:18                                                                                                                      
done.
Downloading file random_large_data/200mb.file ... 
Downloading 100% |oooooooooooooooooooooooooooooooooooooooo| DONE IN 00:06:40                                                                                                                      
done.

PR + rate_limit = "524288"

Skipping item - excluded by skip_dir config: /random_files
Downloading file random_large_data/50mb.file ... 
Downloading 100% |oooooooooooooooooooooooooooooooooooooooo| DONE IN 00:01:39                                                                                                                      
done.
Downloading file random_large_data/100mb.file ... 
Downloading 100% |oooooooooooooooooooooooooooooooooooooooo| DONE IN 00:03:17                                                                                                                      
done.
Downloading file random_large_data/200mb.file ... 
Downloading 100% |oooooooooooooooooooooooooooooooooooooooo| DONE IN 00:06:30                                                                                                                      
done.
Processing 203 OneDrive items to ensure consistent local state
Skipping item - excluded by skip_dir config: /random_files

@abraunegg abraunegg linked an issue Jul 27, 2022 that may be closed by this pull request
Bug: Download progress bar doesn't always reach 100% when rate_limit is set #2054
Closed
@abraunegg
Update onedrive.d
9d33b34 
* make sure that 'dataPerSegment' is a whole number to avoid dealing with any factional numbers
@abraunegg
Update onedrive.d
d4de967 
* Update PR
@abraunegg
Update onedrive.d
ee318db 
* Only calculate dataPerSegment if we need to
@abraunegg abraunegg added this to the v2.4.21 milestone Jul 28, 2022
@abraunegg abraunegg merged commit b2991fd into master Jul 28, 2022
@abraunegg abraunegg deleted the investigate-manjaro-curl-issue branch July 28, 2022 21:07
@abraunegg
Copy link
Owner Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.21
Development

Successfully merging this pull request may close these issues.

Bug: Download progress bar doesn't always reach 100% when rate_limit is set
1 participant
@abraunegg