reinitialize sync engine after three failed trials #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - and makes the application more robust when there is a flaky Internet connection - thanks We just need to update the log message output otherwise this is good to merge |
abraunegg
reviewed
Dec 11, 2018
abraunegg
reviewed
Dec 11, 2018
abraunegg
requested changes
Dec 11, 2018
after extended suspend, or bad connection, the connection to OD might go stale. In this case, no connection works out and currently we get Syncing changes from OneDrive ... Retrial sync count: 1: Failure when receiving data from the peer on handle 56409DBD3960 Syncing changes from OneDrive ... Retrial sync count: 2: Failure when receiving data from the peer on handle 56409DBD3960 Syncing changes from OneDrive ... No network connection to Microsoft OneDrive Service, skipping sync and this continues ad infinitum. Change the last action to re-initialize the sync engine. With this change we get the following events (tested by blocking onedrive via iptables): Dec 11 13:06:55 Syncing changes from OneDrive ... Dec 11 13:07:50 Syncing changes from OneDrive ... Dec 11 13:12:50 Retrial sync count: 1: Timeout was reached on handle 556C7172EA60 Dec 11 13:12:50 Syncing changes from OneDrive ... Dec 11 13:12:59 Retrial sync count: 2: Couldn't connect to server on handle 556C7172EA60 Dec 11 13:12:59 Syncing changes from OneDrive ... Dec 11 13:13:08 Giving up on sync after three trials: Couldn't connect to server on handle 556C7172EA60 Dec 11 13:13:08 Pesistent connection errors, reinitializing connection Dec 11 13:14:01 Cannot initialize connection to OneDrive Dec 11 13:14:55 Cannot initialize connection to OneDrive Dec 11 13:15:42 Syncing changes from OneDrive ... Dec 11 13:16:38 Syncing changes from OneDrive ... (iptables rules removed at 13:15:15)
norbusan
force-pushed
the
norbert/reinit-outdated-handle
branch
from
9ac3ae5
to
65131e6
Compare
|
Thanks, changed the commit to use the new log message and pushed out. I cannot approve the changes, so please do that and merge. Thanks a lot. |
abraunegg
approved these changes
Dec 12, 2018
|
Thanks! |
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after extended suspend, or bad connection, the connection to OD might
go stale. In this case, no connection works out and currently we get
and this continues ad infinitum. Change the last action to re-initialize
the sync engine. With this change we get the following events (tested by
blocking onedrive via iptables):
(iptables rules removed at 13:15:15)