Fix package creation and improve Makefile a bit #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2018 21:31
Without it, building of distribution package fails.
`make uninstall` is called by root user, which shouldn't be a primary user anyway,, so removing ~/.config/onedrive will not work for other, normal users.
abraunegg
approved these changes
May 24, 2018
abraunegg
approved these changes
May 24, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile improvements:
make DESTDIR=~/out installand PKGBUILD),rm -rvf ~/.config/onedrive, because in most cases, it's ineffective -make uninstallis called viasuorsudocommands, and user-level configuration definitively isn't in/root/.configI'm not sure still about directory creation and permission changes in Makefile - I think those should be managed by application itself, and not use
/var/logpath except when ran as system-level daemon.