Make the 'Syncing changes' messages all vlog

[sweharris]

The Syncing changes messages appear in the log very frequently (e.g. every 49 seconds) even if there is nothing to do, which will cause large log files over time. This change makes this message only appear in verbose mode.

[abraunegg]

@sweharris

The Syncing changes messages appear in the log very frequently (e.g. every 49 seconds) even if there is nothing to do, which will cause large log files over time. This change makes this message only appear in verbose mode.

Understand the driver behind this, however the intent here was that these messages always presented a message when doing a sync, even when not using --verbose so you had an idea of what it was doing.

I totally understand however, that in a non-verbose mode & utilising monitor, then the frequency of the message if "nothing" is going on is needless.

Perhaps, a better mechanism here is:

• If not in monitor mode, write out the log line as per normal
• In in monitor mode & verbose mode, write out the log line as per normal else skip

Thoughts?

[sweharris]

Ah, I had noted there was already a

log.vlog("Syncing changes from this selected path: ", singleDirectory);

line (line 617), so followed that. Maybe that's an existing bug :-)

I think your idea is probably more complete! The logical may be simplified to "if (not monitor) or verbose then write line"

[abraunegg]

@sweharris
Closing this PR in favour of #376

Please can you review #376 & comment

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.