-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for propagating environment variables #110
base: master
Are you sure you want to change the base?
Conversation
(with-output-to-string | ||
(with-current-buffer standard-output | ||
(shell-command cmd t "*kubel stderr*")))) | ||
(let ((env-values (kubel--env-values))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the only place where you need to do that? what about kubel--exec
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the only place where it was required for me to unblock it and have a working kubel version in my envrc
based setup.
Note that it still isn't perfect and has some shortcomings which I plan to address in a subsequent PR. But I believe those changes are going to be slightly big (I have a working copy locally, but I'm still testing out various scenarios).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect things are going to be very wonky if the changes are only applied to this function and not also kubel--exec
Thank you for submitting this! I left a few comments. Could you also please update the doc to show intended usage? |
Right now,
kubel
works when the apropriate credential is part of~/.kube
. But it doesn't work,if I haveKUBECONFIG
environment variable pointing out to somewhere else (basically if it's not globally set). If you use something likedirenv
to have project specific environment variable, kubel doesn't work there. And at work, I usually have separate clusters each being managed in their own directory.This PR adds supports for propagating environment variables and making kubel working in those environment. For EKS cluster, I have to often propagate some extra environment variables to make it work with
kubel
: