Fixes to the ABS installer PR #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if the package file is not present, calls to `require` shouldn't fail
* a package `user/package` might contain different abs files (eg. `user/package/file.abs`). When we resolve calls to `require("package/file.abs")` we should only take `package`, and not the whole `package/file.abs`
* saving aliases was only working for the first package installed, now the installer will save all modules that are being installed locally
* when including a module, if a file is not specified (`require("module")`), we will try to load the `index.abs` file by default
… with a .abs file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireshouldn't failuser/packagemight contain different abs files (eg.user/package/file.abs). When we resolve calls torequire("package/file.abs")we should only takepackage, and not the wholepackage/file.absrequire("module")), we will try to load theindex.absfile by default/cc @mingwho