Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supppress unused variable warning for recent gcc #372

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

pizzard
Copy link
Contributor

@pizzard pizzard commented Aug 22, 2019

gcc7.2 complains with:

'stacktraces_enabler' defined but not used [-Wunused-variable] 
static int stacktraces_enabler = []() { 

gcc complains with: 
```
'stacktraces_enabler' defined but not used [-Wunused-variable] 
static int stacktraces_enabler = []() { 
```
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@zhangxy988
Copy link
Contributor

LGTM. Thanks for the PR. I will run a quick sanity check internally and merge this.

@zhangxy988 zhangxy988 merged commit 0302d1e into abseil:master Aug 23, 2019
absl-federation-github pushed a commit that referenced this pull request Aug 23, 2019
--
d6748c733a70cd74ad9b76a0c9cd6b3fe2cecacf by Xiaoyi Zhang <zhangxy@google.com>:

Remove empty block, to address alerts reported in
#368.

PiperOrigin-RevId: 265099887

--
232e2036b5668d6d1296b881f9347756d84541ee by Derek Mauro <dmauro@google.com>:

Make the Linux Bazel CI scripts test with the exception mode explicitly set.

PiperOrigin-RevId: 265092105

--
942a40696c2c9b833be03e92d22a6ede7bccb6d4 by Xiaoyi Zhang <zhangxy@google.com>:

Import #372.
Suppress the unused variable warning on GCC, i.e. "-Wunused-variable".

PiperOrigin-RevId: 265063925

--
7ef90796b52cbdc260afc77cf47206f9356471d0 by Xiaoyi Zhang <zhangxy@google.com>:

Add quotes to `ABSL_COMMON_INCLUDE_DIRS` since it's a list and may contain a
`;`. This addresses #373.

PiperOrigin-RevId: 265059077

--
43f3ae742e00b83672ad6c5bc5b17fdb8f9fe6fe by Gennadiy Rozental <rogeeff@google.com>:

Internal re-organization

PiperOrigin-RevId: 264913945

--
6a2adf9c08ee1d98cc6b2855a676345c6495294a by Andy Soffer <asoffer@google.com>:

Publicly expose type names for uniform interval tags as in, for example, absl::IntervalClosedClosedTag, and add equality comparison operators.

PiperOrigin-RevId: 264861162

--
3c90c6e05fd61d56b419cd2d39dab8f17b8711b8 by Abseil Team <absl-team@google.com>:

Add validity check on returned frame pointer.

PiperOrigin-RevId: 264858823

--
2db87e0cfa0c6bea7ba81684b834cb8a73b7d748 by Gennadiy Rozental <rogeeff@google.com>:

Add MUST_USE_RESULT attribute to absl::GetFlag to prevent accidental misuse.

PiperOrigin-RevId: 264782762
GitOrigin-RevId: d6748c733a70cd74ad9b76a0c9cd6b3fe2cecacf
Change-Id: I169e9c5358e4f63000c1255e806d26b8afecf5ff
absl-federation-github pushed a commit that referenced this pull request Feb 25, 2020
  - 0033c9e Fix build on FreeBSD/powerpc (#616) by kgotlinux <60880393+kgotlinux@users.noreply.github.com>
  - 0d5ce27 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b69c7d8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2a5633f Merge "Export of internal Abseil changes" by Xiaoyi Zhang <zhangxy@google.com>
  - f9b3d6e Add RISCV support to GetProgramCounter() (#621) by Khem Raj <raj.khem@gmail.com>
  - 0232c87 Add missing ABSL_HAVE_VDSO_SUPPORT conditional (#622) by Sinan Kaya <41809318+franksinankaya@users.noreply.github.com>
  - 3c81410 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c44657f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 98eb410 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bf78e97 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d95d156 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 24713a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 72382c2 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 08a7e7b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 36bcd95 Fix pointer format specifier in documentation (#614) by Andre Nguyen <andre-nguyen@users.noreply.github.com>
  - 0f86336 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c512f11 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 37dd256 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4442770 fix: Add support for more ARM processors detection (#608) by Andre Nguyen <andre-nguyen@users.noreply.github.com>
  - 159bf2b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a2e6ade Use https links. (#586) by nlewycky <nicholas@mxc.ca>
  - 564001a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b3aaac8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 63ee2f8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a048203 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1de0166 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ad904b6 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2923513 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bf86cfe Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 12bc53e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1e39f86 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 77f8700 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d659fe5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a4b757b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0514227 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 7f4fe64 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 16d9fd5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bcaae60 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8ba96a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2103fd9 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3df7b52 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - fa8c751 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 85092b4 Fix Conan builds (#400) by Adrian Ostrowski <adr.ostrowski@gmail.com>
  - e96ae22 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 20de2db Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 846e5db Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8207907 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 078b89b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 19b021c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ecc0033 Always enable proper symbolize implementation on Windows ... by Loo Rong Jie <loorongjie@gmail.com>
  - 2796d50 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - e4c8d0e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a15364c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ab3552a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - e9f9000 Fix ABSL_WAITER_MODE detection for mingw (#342) by Joe Sylve <Joe.Sylve@gmail.com>
  - abea769 Fix ABSL_HAVE_ALARM check on mingw (#341) by Joe Sylve <Joe.Sylve@gmail.com>
  - 25597bd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - aad33fe Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8fe7214 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - debac94 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 882b350 Fix spelling errors (#384) by Sungmann Cho <55860394+chosungmann@users.noreply.github.com>
  - 502efe6 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ccdd1d5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ddf8e52 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 6ec1362 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ac78ffc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 5374c56 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 97c1664 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 325fd7b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 83c1d65 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - eb6b7bd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 9ddac55 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1948f6f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a0d1e09 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2d2d7fb Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0302d1e supppress unused variable warning for gcc (#372) by Martin <pizzard@users.noreply.github.com>
  - 262d74b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f0afae0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0e7afdc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 9a41ffd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 36910d3 [bazel] Add fixes for --incompatible_load_cc_rules_from_b... by Yannic <contact@yannic-bonenberger.com>
  - aae8143 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d9aa92d Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 321ab53 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4ef5740 Export of internal Abseil changes by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 0033c9e
Change-Id: I8a2b70063cb3ab40c6943a6db0fe40cae71ed8d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants