Fix spelling errors #384
Merged
Fix spelling errors #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbxx
reviewed
Sep 27, 2019
mbxx
reviewed
Sep 27, 2019
There was a problem hiding this comment.
Thank you! Looks great, but if you wouldn't mind, it would be better to address the misspelling in absl/time/internal/cctz/include/cctz/civil_time.h upstream (I left a comment pointing at https://github.com/google/cctz/blob/master/include/cctz/civil_time.h, which is the upstream source of the file)
aligment -> alignment constructable -> constructible constuctible -> constructible contructed -> constructed destructable -> destructible futher -> further implcit -> implicit implemenation -> implementation intrinics -> intrinsics
|
@mbxx Thanks for the review! I opened a pull request to address your comment at google/cctz#127 Please take a look. |
|
Since google/cctz#127 was merged, I'm closing this. Thank you for the contribution! |
|
@CJ-Johnson I’m just wondering why this PR has been closed without merging? |
|
Thank you for the ping! I misread the comment stream and understood google/cctz#127 to be the entire scope of this PR. That was incorrect. My apologies, for that. I will work on merging this, now. |
absl-federation-github
pushed a commit
that referenced
this pull request
Sep 30, 2019
-- 3f99b3ea921adc3607b6f308646db9f893c4d55d by CJ Johnson <johnsoncj@google.com>: Import of CCTZ from GitHub. PiperOrigin-RevId: 272051845 -- 9a62831d763e39936239ff53460ede42c2a73afb by CJ Johnson <johnsoncj@google.com>: Fix spelling errors #384 PiperOrigin-RevId: 272015607 -- b9b51815d52cf17e987636d83adea28c262f3f1a by Abseil Team <absl-team@google.com>: Fix a spelling error aligment -> alignment PiperOrigin-RevId: 271629812 -- 7965acbe7d7b5de18cfb2f2e5c0c18759313a229 by Abseil Team <absl-team@google.com>: Internal build system change. PiperOrigin-RevId: 271476858 -- 0b4508cbeff246c76762f80cbf8753a7414e4023 by Abseil Team <absl-team@google.com>: Internal change PiperOrigin-RevId: 271450732 -- f8cb1aa2196cf2a5e7a474038519da8024090e7f by Samuel Benzaquen <sbenza@google.com>: Internal change PiperOrigin-RevId: 271418668 GitOrigin-RevId: 3f99b3ea921adc3607b6f308646db9f893c4d55d Change-Id: I8743e60d001d42f24cd7494f106eeb2eb07e6526
absl-federation-github
pushed a commit
that referenced
this pull request
Feb 25, 2020
- 0033c9e Fix build on FreeBSD/powerpc (#616) by kgotlinux <60880393+kgotlinux@users.noreply.github.com> - 0d5ce27 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b69c7d8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2a5633f Merge "Export of internal Abseil changes" by Xiaoyi Zhang <zhangxy@google.com> - f9b3d6e Add RISCV support to GetProgramCounter() (#621) by Khem Raj <raj.khem@gmail.com> - 0232c87 Add missing ABSL_HAVE_VDSO_SUPPORT conditional (#622) by Sinan Kaya <41809318+franksinankaya@users.noreply.github.com> - 3c81410 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c44657f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 98eb410 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bf78e97 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d95d156 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 24713a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 72382c2 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 08a7e7b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 36bcd95 Fix pointer format specifier in documentation (#614) by Andre Nguyen <andre-nguyen@users.noreply.github.com> - 0f86336 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c512f11 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 37dd256 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4442770 fix: Add support for more ARM processors detection (#608) by Andre Nguyen <andre-nguyen@users.noreply.github.com> - 159bf2b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a2e6ade Use https links. (#586) by nlewycky <nicholas@mxc.ca> - 564001a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b3aaac8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 63ee2f8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a048203 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1de0166 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ad904b6 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2923513 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bf86cfe Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 12bc53e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1e39f86 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 77f8700 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d659fe5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a4b757b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0514227 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 7f4fe64 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 16d9fd5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bcaae60 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8ba96a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2103fd9 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3df7b52 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - fa8c751 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 85092b4 Fix Conan builds (#400) by Adrian Ostrowski <adr.ostrowski@gmail.com> - e96ae22 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 20de2db Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 846e5db Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8207907 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 078b89b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 19b021c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ecc0033 Always enable proper symbolize implementation on Windows ... by Loo Rong Jie <loorongjie@gmail.com> - 2796d50 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - e4c8d0e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a15364c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ab3552a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - e9f9000 Fix ABSL_WAITER_MODE detection for mingw (#342) by Joe Sylve <Joe.Sylve@gmail.com> - abea769 Fix ABSL_HAVE_ALARM check on mingw (#341) by Joe Sylve <Joe.Sylve@gmail.com> - 25597bd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - aad33fe Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8fe7214 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - debac94 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 882b350 Fix spelling errors (#384) by Sungmann Cho <55860394+chosungmann@users.noreply.github.com> - 502efe6 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ccdd1d5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ddf8e52 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 6ec1362 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ac78ffc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 5374c56 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 97c1664 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 325fd7b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 83c1d65 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - eb6b7bd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 9ddac55 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1948f6f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a0d1e09 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2d2d7fb Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0302d1e supppress unused variable warning for gcc (#372) by Martin <pizzard@users.noreply.github.com> - 262d74b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f0afae0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0e7afdc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 9a41ffd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 36910d3 [bazel] Add fixes for --incompatible_load_cc_rules_from_b... by Yannic <contact@yannic-bonenberger.com> - aae8143 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d9aa92d Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 321ab53 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4ef5740 Export of internal Abseil changes by Abseil Team <absl-team@google.com> GitOrigin-RevId: 0033c9e Change-Id: I8a2b70063cb3ab40c6943a6db0fe40cae71ed8d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligment -> alignment
constructable -> constructible
constuctible -> constructible
contructed -> constructed
destructable -> destructible
futher -> further
implcit -> implicit
implemenation -> implementation
intrinics -> intrinsics