Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer format specifier in documentation #614

Merged
merged 1 commit into from Feb 4, 2020

Conversation

andre-nguyen
Copy link
Contributor

The format specifier %*p is invalid. As specified here https://abseil.io/docs/cpp/guides/format#conversion-specifiers, the %p specifier allows printing out the address of the pointer; which is what we want to do with the program counter.

@suertreus suertreus self-assigned this Feb 4, 2020
@suertreus suertreus merged commit 36bcd95 into abseil:master Feb 4, 2020
absl-federation-github pushed a commit that referenced this pull request Feb 4, 2020
--
1bc4d36e13fb9175ea8cdaa00213aa9d4417c669 by Andy Getzendanner <durandal@google.com>:

Fix pointer format specifier in documentation

Import of #614

PiperOrigin-RevId: 293227540

--
c7b43b30493c4fb5f2ec3264672b08bfe1ea3709 by Abseil Team <absl-team@google.com>:

Internal change.

PiperOrigin-RevId: 293160245

--
64439365e2b4a0b5e51ae0a7dafdb15912402dfd by Shahriar Rouf <nafi@google.com>:

Add benchmarks for string_view: BM_CompareFirstOneLess and BM_CompareSecondOneLess.

PiperOrigin-RevId: 293031676

--
b273b420cab24a6e3f487430987e09f4eb1caec4 by Greg Falcon <gfalcon@google.com>:

Remove an unreachable line from charconv.cc.

Fixes github issue #613.

PiperOrigin-RevId: 292980167

--
70babb5f7a3d9fdd00a2b3085c3c2b9fe0265c79 by Gennadiy Rozental <rogeeff@google.com>:

Move GetFlag implementation into FlagImpl.

This change will allow us to hide details of GetFlag overloads inside implementation detais. Eventually we'll migrate to a different implementation. No semantic changes in this CL.

PiperOrigin-RevId: 292930847

--
94bee7b7cc31e0167ee4b953281c1e78c96a574a by Abseil Team <absl-team@google.com>:

Clarification in absl::Exponential documentation.

PiperOrigin-RevId: 292912672

--
d6916d30c5c1d3ee9ae46d69ec0a166a760c99c7 by Derek Mauro <dmauro@google.com>:

Make AtomicHook constant-initializable on Clang for Windows.

Only mark AtomicHook as constant-initializable on platforms where it
is actually constant-initializable.

PiperOrigin-RevId: 292655939
GitOrigin-RevId: 1bc4d36e13fb9175ea8cdaa00213aa9d4417c669
Change-Id: I090b231a0ca0d92868e494ab5b3fa86c902889d5
@andre-nguyen andre-nguyen deleted the patch-1 branch February 5, 2020 01:20
absl-federation-github pushed a commit that referenced this pull request Feb 25, 2020
  - 0033c9e Fix build on FreeBSD/powerpc (#616) by kgotlinux <60880393+kgotlinux@users.noreply.github.com>
  - 0d5ce27 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b69c7d8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2a5633f Merge "Export of internal Abseil changes" by Xiaoyi Zhang <zhangxy@google.com>
  - f9b3d6e Add RISCV support to GetProgramCounter() (#621) by Khem Raj <raj.khem@gmail.com>
  - 0232c87 Add missing ABSL_HAVE_VDSO_SUPPORT conditional (#622) by Sinan Kaya <41809318+franksinankaya@users.noreply.github.com>
  - 3c81410 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c44657f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 98eb410 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bf78e97 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d95d156 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 24713a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 72382c2 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 08a7e7b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 36bcd95 Fix pointer format specifier in documentation (#614) by Andre Nguyen <andre-nguyen@users.noreply.github.com>
  - 0f86336 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c512f11 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 37dd256 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4442770 fix: Add support for more ARM processors detection (#608) by Andre Nguyen <andre-nguyen@users.noreply.github.com>
  - 159bf2b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a2e6ade Use https links. (#586) by nlewycky <nicholas@mxc.ca>
  - 564001a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b3aaac8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 63ee2f8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a048203 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1de0166 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ad904b6 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2923513 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bf86cfe Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 12bc53e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1e39f86 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 77f8700 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d659fe5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a4b757b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0514227 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 7f4fe64 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 16d9fd5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bcaae60 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8ba96a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2103fd9 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3df7b52 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - fa8c751 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 85092b4 Fix Conan builds (#400) by Adrian Ostrowski <adr.ostrowski@gmail.com>
  - e96ae22 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 20de2db Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 846e5db Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8207907 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 078b89b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 19b021c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ecc0033 Always enable proper symbolize implementation on Windows ... by Loo Rong Jie <loorongjie@gmail.com>
  - 2796d50 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - e4c8d0e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a15364c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ab3552a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - e9f9000 Fix ABSL_WAITER_MODE detection for mingw (#342) by Joe Sylve <Joe.Sylve@gmail.com>
  - abea769 Fix ABSL_HAVE_ALARM check on mingw (#341) by Joe Sylve <Joe.Sylve@gmail.com>
  - 25597bd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - aad33fe Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8fe7214 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - debac94 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 882b350 Fix spelling errors (#384) by Sungmann Cho <55860394+chosungmann@users.noreply.github.com>
  - 502efe6 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ccdd1d5 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ddf8e52 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 6ec1362 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ac78ffc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 5374c56 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 97c1664 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 325fd7b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 83c1d65 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - eb6b7bd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 9ddac55 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1948f6f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a0d1e09 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2d2d7fb Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0302d1e supppress unused variable warning for gcc (#372) by Martin <pizzard@users.noreply.github.com>
  - 262d74b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f0afae0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0e7afdc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 9a41ffd Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 36910d3 [bazel] Add fixes for --incompatible_load_cc_rules_from_b... by Yannic <contact@yannic-bonenberger.com>
  - aae8143 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d9aa92d Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 321ab53 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4ef5740 Export of internal Abseil changes by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 0033c9e
Change-Id: I8a2b70063cb3ab40c6943a6db0fe40cae71ed8d7
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
--
1bc4d36e13fb9175ea8cdaa00213aa9d4417c669 by Andy Getzendanner <durandal@google.com>:

Fix pointer format specifier in documentation

Import of abseil#614

PiperOrigin-RevId: 293227540

--
c7b43b30493c4fb5f2ec3264672b08bfe1ea3709 by Abseil Team <absl-team@google.com>:

Internal change.

PiperOrigin-RevId: 293160245

--
64439365e2b4a0b5e51ae0a7dafdb15912402dfd by Shahriar Rouf <nafi@google.com>:

Add benchmarks for string_view: BM_CompareFirstOneLess and BM_CompareSecondOneLess.

PiperOrigin-RevId: 293031676

--
b273b420cab24a6e3f487430987e09f4eb1caec4 by Greg Falcon <gfalcon@google.com>:

Remove an unreachable line from charconv.cc.

Fixes github issue abseil#613.

PiperOrigin-RevId: 292980167

--
70babb5f7a3d9fdd00a2b3085c3c2b9fe0265c79 by Gennadiy Rozental <rogeeff@google.com>:

Move GetFlag implementation into FlagImpl.

This change will allow us to hide details of GetFlag overloads inside implementation detais. Eventually we'll migrate to a different implementation. No semantic changes in this CL.

PiperOrigin-RevId: 292930847

--
94bee7b7cc31e0167ee4b953281c1e78c96a574a by Abseil Team <absl-team@google.com>:

Clarification in absl::Exponential documentation.

PiperOrigin-RevId: 292912672

--
d6916d30c5c1d3ee9ae46d69ec0a166a760c99c7 by Derek Mauro <dmauro@google.com>:

Make AtomicHook constant-initializable on Clang for Windows.

Only mark AtomicHook as constant-initializable on platforms where it
is actually constant-initializable.

PiperOrigin-RevId: 292655939
GitOrigin-RevId: 1bc4d36e13fb9175ea8cdaa00213aa9d4417c669
Change-Id: I090b231a0ca0d92868e494ab5b3fa86c902889d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants