Add forgotten ifdef conditionals #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sinan Kaya <sinan.kaya@microsoft.com>
derekmauro
reviewed
Feb 20, 2020
CMakeLists.txt
Outdated
| @@ -86,6 +86,9 @@ option(ABSL_USE_GOOGLETEST_HEAD | |||
|
|
|||
| option(ABSL_RUN_TESTS "If ON, Abseil tests will be run." OFF) | |||
|
|
|||
| # link fails on arm64 and x86-64 without this | |||
| set(CMAKE_POSITION_INDEPENDENT_CODE ON) | |||
There was a problem hiding this comment.
I talked with @asoffer about this and we don't think adding this unconditionally is the right thing to do since it can have performance implications. We think that a recent change (37dd256) actually broke adding this when -DBUILD_SHARED_LIBS=ON is specified.
I suggest we revert this change try to figure it out separately from the VDSO support change.
There was a problem hiding this comment.
ok, I'll drop this
franksinankaya
force-pushed
the
frkaya/yoctomasterfixes
branch
from
5efff92
to
cd26cd1
Compare
franksinankaya
changed the title
absl-federation-github
pushed a commit
that referenced
this pull request
Feb 21, 2020
-- 00f5301405423005d9129935c05f20155536cc1a by CJ Johnson <johnsoncj@google.com>: Removes usage of std::aligned_storage from Abseil implementation details PiperOrigin-RevId: 296492301 -- fc11d15f91764612fba080669d2381dc181df52b by Abseil Team <absl-team@google.com>: Fix absl::bind_front documentation. PiperOrigin-RevId: 296482945 -- 0164c595c129c46bf21ae74eba5399a1da5f140b by Gennadiy Rozental <rogeeff@google.com>: Automated g4 rollback of changelist 296320700. PiperOrigin-RevId: 296439968 -- 1eb295700758ca0894d872b2de7c675b4ad679af by Abseil Team <absl-team@google.com>: Removes duplicate comments. PiperOrigin-RevId: 296433214 -- c30c01caae02d2fa4ef783d988de6bebb9757c39 by Derek Mauro <dmauro@google.com>: Merge GitHub #621: Add RISCV support to GetProgramCounter() Fixes #621 PiperOrigin-RevId: 296351174 -- 95d4498167596fd7543e025bdfe9a8da9e2ca3c8 by Abseil Team <absl-team@google.com>: Automated g4 rollback of changelist 296320700. PiperOrigin-RevId: 296348701 -- b193f0543e0cec54dddb2ed51f45dc489c8d06d5 by Gennadiy Rozental <rogeeff@google.com>: Change TryParse interface to return managed value. In addition introduce companion StoreValue routine which consumes pointer to source value and stores the value inside of FlagImpl. In a follow up CL we will change StoreValue implementation to behave differently depending on "value storage kind". We also rename default_src_ to default_value_. PiperOrigin-RevId: 296320700 -- 57e942b485d12912a0a8d0d0b35fa2a62847020f by Derek Mauro <dmauro@google.com>: Merge GitHub #622 * Add missing #ifdef conditionals for ABSL_HAVE_VDSO_SUPPORT PiperOrigin-RevId: 296272830 GitOrigin-RevId: 00f5301405423005d9129935c05f20155536cc1a Change-Id: I1b05eeaf1280f95fb0a2c5f3654995a87c792893
absl-federation-github
pushed a commit
that referenced
this pull request
Feb 25, 2020
- 0033c9e Fix build on FreeBSD/powerpc (#616) by kgotlinux <60880393+kgotlinux@users.noreply.github.com> - 0d5ce27 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b69c7d8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2a5633f Merge "Export of internal Abseil changes" by Xiaoyi Zhang <zhangxy@google.com> - f9b3d6e Add RISCV support to GetProgramCounter() (#621) by Khem Raj <raj.khem@gmail.com> - 0232c87 Add missing ABSL_HAVE_VDSO_SUPPORT conditional (#622) by Sinan Kaya <41809318+franksinankaya@users.noreply.github.com> - 3c81410 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c44657f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 98eb410 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bf78e97 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d95d156 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 24713a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 72382c2 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 08a7e7b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 36bcd95 Fix pointer format specifier in documentation (#614) by Andre Nguyen <andre-nguyen@users.noreply.github.com> - 0f86336 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c512f11 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 37dd256 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4442770 fix: Add support for more ARM processors detection (#608) by Andre Nguyen <andre-nguyen@users.noreply.github.com> - 159bf2b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a2e6ade Use https links. (#586) by nlewycky <nicholas@mxc.ca> - 564001a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b3aaac8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 63ee2f8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a048203 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1de0166 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ad904b6 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2923513 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bf86cfe Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 12bc53e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1e39f86 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 77f8700 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d659fe5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a4b757b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0514227 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 7f4fe64 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 16d9fd5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bcaae60 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8ba96a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2103fd9 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3df7b52 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - fa8c751 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 85092b4 Fix Conan builds (#400) by Adrian Ostrowski <adr.ostrowski@gmail.com> - e96ae22 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 20de2db Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 846e5db Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8207907 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 078b89b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 19b021c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ecc0033 Always enable proper symbolize implementation on Windows ... by Loo Rong Jie <loorongjie@gmail.com> - 2796d50 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - e4c8d0e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a15364c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ab3552a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - e9f9000 Fix ABSL_WAITER_MODE detection for mingw (#342) by Joe Sylve <Joe.Sylve@gmail.com> - abea769 Fix ABSL_HAVE_ALARM check on mingw (#341) by Joe Sylve <Joe.Sylve@gmail.com> - 25597bd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - aad33fe Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8fe7214 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - debac94 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 882b350 Fix spelling errors (#384) by Sungmann Cho <55860394+chosungmann@users.noreply.github.com> - 502efe6 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ccdd1d5 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ddf8e52 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 6ec1362 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ac78ffc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 5374c56 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 97c1664 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 325fd7b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 83c1d65 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - eb6b7bd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 9ddac55 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1948f6f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a0d1e09 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2d2d7fb Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0302d1e supppress unused variable warning for gcc (#372) by Martin <pizzard@users.noreply.github.com> - 262d74b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f0afae0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0e7afdc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 9a41ffd Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 36910d3 [bazel] Add fixes for --incompatible_load_cc_rules_from_b... by Yannic <contact@yannic-bonenberger.com> - aae8143 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d9aa92d Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 321ab53 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4ef5740 Export of internal Abseil changes by Abseil Team <absl-team@google.com> GitOrigin-RevId: 0033c9e Change-Id: I8a2b70063cb3ab40c6943a6db0fe40cae71ed8d7
rongjiecomputer
pushed a commit
to rongjiecomputer/abseil-cpp
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Sinan Kaya <sinan.kaya@microsoft.com>
rongjiecomputer
pushed a commit
to rongjiecomputer/abseil-cpp
that referenced
this pull request
Oct 8, 2020
-- 00f5301405423005d9129935c05f20155536cc1a by CJ Johnson <johnsoncj@google.com>: Removes usage of std::aligned_storage from Abseil implementation details PiperOrigin-RevId: 296492301 -- fc11d15f91764612fba080669d2381dc181df52b by Abseil Team <absl-team@google.com>: Fix absl::bind_front documentation. PiperOrigin-RevId: 296482945 -- 0164c595c129c46bf21ae74eba5399a1da5f140b by Gennadiy Rozental <rogeeff@google.com>: Automated g4 rollback of changelist 296320700. PiperOrigin-RevId: 296439968 -- 1eb295700758ca0894d872b2de7c675b4ad679af by Abseil Team <absl-team@google.com>: Removes duplicate comments. PiperOrigin-RevId: 296433214 -- c30c01caae02d2fa4ef783d988de6bebb9757c39 by Derek Mauro <dmauro@google.com>: Merge GitHub abseil#621: Add RISCV support to GetProgramCounter() Fixes abseil#621 PiperOrigin-RevId: 296351174 -- 95d4498167596fd7543e025bdfe9a8da9e2ca3c8 by Abseil Team <absl-team@google.com>: Automated g4 rollback of changelist 296320700. PiperOrigin-RevId: 296348701 -- b193f0543e0cec54dddb2ed51f45dc489c8d06d5 by Gennadiy Rozental <rogeeff@google.com>: Change TryParse interface to return managed value. In addition introduce companion StoreValue routine which consumes pointer to source value and stores the value inside of FlagImpl. In a follow up CL we will change StoreValue implementation to behave differently depending on "value storage kind". We also rename default_src_ to default_value_. PiperOrigin-RevId: 296320700 -- 57e942b485d12912a0a8d0d0b35fa2a62847020f by Derek Mauro <dmauro@google.com>: Merge GitHub abseil#622 * Add missing #ifdef conditionals for ABSL_HAVE_VDSO_SUPPORT PiperOrigin-RevId: 296272830 GitOrigin-RevId: 00f5301405423005d9129935c05f20155536cc1a Change-Id: I1b05eeaf1280f95fb0a2c5f3654995a87c792893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.