Ensure interface nullable types can be implemented by non-nullable types #1009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987
Two cases are added to the schema:
list_of(non_null(type))
andnon_null(list_of(non_null(type)))
.From my reading of the spec these should all validate.
https://spec.graphql.org/draft/#IsValidImplementationFieldType()
I did find that it is not validated whether the object implements
the field's arguments as specified by the interface. Also that the object
does not implement extra non-nullable arguments that are not specified in the interface.
From the spec
I'll create an issue for this.