Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry phase when subscription config errors #1321

Conversation

michaelcaterisano
Copy link
Contributor

@michaelcaterisano michaelcaterisano commented Jun 12, 2024

What

Ensuring that telemetry events are fired when subscription config returns an error

Why

We would like to be able to hook into these events even when subscription config returns an error.

Testing

Wrote a new test to check that this functionality works. I'd also note that there are three failing tests on main that are unrelated to this change.

@michaelcaterisano michaelcaterisano marked this pull request as ready for review June 12, 2024 19:05
@michaelcaterisano michaelcaterisano changed the title add telemetry phrase when subscription config errors add telemetry phase when subscription config errors Jun 12, 2024
Copy link

@cschiewek cschiewek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's room for improvement here, as this can still potentially discard phases we might want to run, but likely out of scope for this PR. 👍

@michaelcaterisano michaelcaterisano merged commit 358e273 into absinthe-graphql:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants