Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update Provision service #1658

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: 0x6f736f646f blackd0t@protonmail.com

What does this do?

It updates provision tools to use latest sdk config file

Which issue(s) does this PR fix/relate to?

No

List any changes that modify/break current functionality

Nothing

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

N/A

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>
Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>
@rodneyosodo rodneyosodo requested a review from a team as a code owner September 28, 2022 16:29
@dborovcanin dborovcanin changed the title NOISSUE - Update Provision NOISSUE - Update Provision service Sep 28, 2022
@@ -47,6 +47,10 @@ Two output formats supported: human-readable plain text and JSON.
Before use you need a `mfconn.toml` - a TOML file that describes Mainflux connection data (channels, thingIDs, thingKeys, certs).
You can use `provision` tool (in tools/provision) to create this TOML config file.

```bash
./provision -u test@mainflux.com -p test1234 --host http://127.0.0.1 --num 100 > ../mqtt-bench/mfconn.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Go here and paths relative to Mainflux root:

go run tools/provision/cmd/main.go -u test@mainflux.com -p test1234 --host http://127.0.0.1 --num 100 > tools/mqtt-bench/mfconn.toml 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this apply also to provision?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it like that.

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the path in the tools/provision/README.md, as well.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 8c21181 into absmach:master Oct 21, 2022
@rodneyosodo rodneyosodo deleted the fix-tools branch October 22, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants