Fix default value for no-client argument in command configuration
#1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
🦋 Changeset detectedLatest commit: 1e3b70e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the default value for the "no-client" argument in the command configuration based on issues #1105 and #1099. Key changes include:
- Updating the default value for "no-client" in index.ts to the inverse of codeGenBaseConfig.generateClient.
- Adding/updating changeset files to document the fix.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .changeset/five-moles-wonder.md | Adds a changeset documenting the patch fix. |
| index.ts | Updates the default logic for the "no-client" argument. |
| .changeset/easy-paths-check.md | Adjusts wording in the changeset for clarity. |
Comments suppressed due to low confidence (1)
index.ts:140
- Ensure that tests are updated or added to verify that the new default behavior for the 'no-client' argument accurately reflects the intended inversion logic.
default: !codeGenBaseConfig.generateClient,
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
Fixes #1099