Set discriminators types before other types than enums #1393
Conversation
🦋 Changeset detectedLatest commit: 3566963 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RoCat
force-pushed
the
discriminators
branch
4 times, most recently
from
49c2f74 to
6d5b065
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
smorimoto
changed the title
Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
force-pushed
the
discriminators
branch
from
6d5b065 to
3566963
Compare
The goal of this merge request is to ensure discriminators are at the (not so) very first place in generation, just after enums.
If they're not, that will cause cyclic errors in typescript.