Uninitialized sliceOptimizationData::type

[matt77hias]

The below code in ImfScanLineInputFile.cpp:

sliceOptimizationData dat;
dat.base      = j.slice ().base;
dat.fill      = fill;
dat.fillValue = j.slice ().fillValue;
dat.offset    = offset;
dat.xStride   = j.slice ().xStride;
dat.yStride   = j.slice ().yStride;
dat.xSampling = j.slice ().xSampling;
dat.ySampling = j.slice ().ySampling;
optData.push_back (dat);

does not assign sliceOptimizationData::type.

Shouldn't data.type = fill ? j.slice ().type : i.channel ().type; be added?

[peterhillman]

Good point! Actually type is never used, because optimization only works if all the channels in optData are HALF channels, so a better solution would be to remove sliceOptimizationData::type completely.
If you'd like to make that change and put in a PR, then go ahead!

[matt77hias]

Moved to #1742.