Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

test(TemplateLibrary): implement test and fix proptypes - I-35 #48

Merged
merged 5 commits into from
May 16, 2019
Merged

test(TemplateLibrary): implement test and fix proptypes - I-35 #48

merged 5 commits into from
May 16, 2019

Conversation

jolanglinais
Copy link
Member

Issue #35

Related Issue #6

Changes

  • Update snapshots
  • Pass in props in tests for PropType warnings
  • Add class names for testing
  • Implement further tests for TemplateLibrary
  • Corrected import name in src/ClauseEditor/index.test.js

Flags

  • Attempted chai, but abandoned when effect keyword was conflicting

@jolanglinais
chore(package): regulate npm package - I-35
8e94c89 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais
test(snapshots): update snapshots - I-35
39705d8 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais
fix(test): pass in props for proptype warnings - I-35
1c40865 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais
feat(TemplateLibrary): add class names for testing - I-35
56a3545 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais
test(TemplateLibrary): implement further tests - I-35
f115ce5 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@jolanglinais jolanglinais added Type: Bug 🐛 Something isn't working Type: Feature Request 🛍️ New feature or request Good First Issue :octocat: Good for newcomers labels May 16, 2019
@jolanglinais jolanglinais self-assigned this May 16, 2019
jeromesimeon
jeromesimeon approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Overlaps with parts of #47 but I think this PR should go first, and #47 should be merged in after.

@jolanglinais jolanglinais merged commit 2dcfdf2 into accordproject:master May 16, 2019
@jolanglinais jolanglinais deleted the jl-tl-test branch May 16, 2019 21:08
@jeromesimeon jeromesimeon mentioned this pull request May 17, 2019
Merged
@jolanglinais jolanglinais mentioned this pull request May 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeromesimeon jeromesimeon jeromesimeon approved these changes

@dselman dselman Awaiting requested review from dselman

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

@DianaLease DianaLease Awaiting requested review from DianaLease

Assignees

@jolanglinais jolanglinais

Labels
Good First Issue :octocat: Good for newcomers Type: Bug 🐛 Something isn't working Type: Feature Request 🛍️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolanglinais @jeromesimeon