Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

fix(build) CI, testing, lerna hoisting, dependencies, demo uses webpack #30

Merged
merged 7 commits into from
Feb 21, 2020

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Feb 21, 2020

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Issue #26 & #28 & #31

This fixes issues running the demo, but also aligns more closely with cicero-ui and other AP lerna-based repositories:

  • Switches the demo from react-scripts to webpack
  • Changes the lerna build to use hoisting
  • Aligns dependencies across all packages (as much as possible)
  • Upgrades to react version 16.11 and other dependencies for consistency with cicero-ui
  • Adds other dependencies found in cicero-ui notably for styling
  • Fixes to tests, adjusts configuration for testing linting and license check
  • Enable CI with Travis
  • Automatic deployment of npm packages through Travis

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
This was referenced Feb 21, 2020
@jeromesimeon jeromesimeon changed the title fix(build) lerna hoisting, fixes dependencies, switches demo to webpack fix(build) CI, lerna hoisting, dependencies, switches demo to webpack Feb 21, 2020
@jeromesimeon jeromesimeon changed the title fix(build) CI, lerna hoisting, dependencies, switches demo to webpack fix(build) CI, testing, lerna hoisting, dependencies, demo uses webpack Feb 21, 2020
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better, thanks @jeromesimeon!

A few little questions:

  1. I notice that you rightly removed most of the compiled code from the dist folders, is there a reason for retaining files in packages/concerto-ui-react/dist/?
  2. Has Travis been set up to match the key that's included here now?

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon
Copy link
Member Author

So much better, thanks @jeromesimeon!

A few little questions:

  1. I notice that you rightly removed most of the compiled code from the dist folders, is there a reason for retaining files in packages/concerto-ui-react/dist/?

No reason, I just missed it! Removed now.

  1. Has Travis been set up to match the key that's included here now?

It has... we'll know if I got it right as soon as we publish a new release.

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@mttrbrts mttrbrts self-requested a review February 21, 2020 15:37
@jeromesimeon jeromesimeon merged commit 190012b into master Feb 21, 2020
@jeromesimeon jeromesimeon deleted the js-fix-webpack-build branch February 21, 2020 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants