This repository has been archived by the owner on May 19, 2020. It is now read-only.
forked from mttrbrts/concerto-form
-
Notifications
You must be signed in to change notification settings - Fork 3
fix(build) CI, testing, lerna hoisting, dependencies, demo uses webpack #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
This was referenced Feb 21, 2020
Closed
jeromesimeon
changed the title
fix(build) lerna hoisting, fixes dependencies, switches demo to webpack
fix(build) CI, lerna hoisting, dependencies, switches demo to webpack
Feb 21, 2020
jeromesimeon
changed the title
fix(build) CI, lerna hoisting, dependencies, switches demo to webpack
fix(build) CI, testing, lerna hoisting, dependencies, demo uses webpack
Feb 21, 2020
jeromesimeon
force-pushed
the
js-fix-webpack-build
branch
from
February 21, 2020 02:31
b46c147
to
dcab41b
Compare
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
jeromesimeon
force-pushed
the
js-fix-webpack-build
branch
from
February 21, 2020 02:38
dcab41b
to
5076e30
Compare
mttrbrts
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better, thanks @jeromesimeon!
A few little questions:
- I notice that you rightly removed most of the compiled code from the
dist
folders, is there a reason for retaining files inpackages/concerto-ui-react/dist/
? - Has Travis been set up to match the key that's included here now?
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
No reason, I just missed it! Removed now.
It has... we'll know if I got it right as soon as we publish a new release. |
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
mttrbrts
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jerome Simeon jeromesimeon@me.com
Issue #26 & #28 & #31
This fixes issues running the demo, but also aligns more closely with
cicero-ui
and other APlerna
-based repositories:react-scripts
towebpack
lerna
build to use hoistingreact
version16.11
and other dependencies for consistency withcicero-ui
cicero-ui
notably for styling